[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2014-11-28 11:26:17
Message-ID: 20141128112617.11306.36576 () probe ! kde ! org
[Download RAW message or body]
--===============6306335819531190479==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120777/#review71055
-----------------------------------------------------------
components/timelinemodel/timelinemodel.h
<https://git.reviewboard.kde.org/r/120777/#comment49627>
I also just realized that the start and end date are QStrings, and not QDates.
Is it easier to work with strings in QML?
components/timelinemodel/timelinemodel.cpp
<https://git.reviewboard.kde.org/r/120777/#comment49626>
Has this been tested?
This assert would be true when m_level is Month or Day.
- Vishesh Handa
On Nov. 26, 2014, 6:11 p.m., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120777/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2014, 6:11 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-mobile
>
>
> Description
> -------
>
> At the moment, Baloo doesn't provide a timeline, which is something that we need for the \
> activefilebrowser. So this new component, is introducing support for the timeline.
>
> Notes
> ===
>
> * Baloocloud component contains the org.kde.baloo component inside it.The reason behind that, is that \
> the implementation for the timeline is kind of terible because of its perfomance.
> * I have put the new component inside the plasma-mobile repository, for the above reason. But if the \
> Baloo team, wants it inside the baloo repo then i can move it. I am fine with both approaches (keep it \
> here or in the baloo repository.
> * If someone has a better idea about the implementation, the pls shoot :)
>
>
>
> Diffs
> -----
>
> CMakeLists.txt 9466447
> components/CMakeLists.txt 536b60e
> components/timelinemodel/CMakeLists.txt PRE-CREATION
> components/timelinemodel/qmldir PRE-CREATION
> components/timelinemodel/timelinemodel.h PRE-CREATION
> components/timelinemodel/timelinemodel.cpp PRE-CREATION
> components/timelinemodel/timelineplugin.h PRE-CREATION
> components/timelinemodel/timelineplugin.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/120777/diff/
>
>
> Testing
> -------
>
> Everything looks ok. The performance is not bad, except from the fact that the implementation is a bit \
> of hackish...
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
--===============6306335819531190479==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120777/">https://git.reviewboard.kde.org/r/120777/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120777/diff/3/?file=330747#file330747line32" style="color: black; \
font-weight: bold; text-decoration: underline;">components/timelinemodel/timelinemodel.h</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px \
solid #C0C0C0;" align="right"><font size="2">32</font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q_PROPERTY</span><span \
class="p">(</span><span class="n">QString</span> <span class="n">endDate</span> <span \
class="n">READ</span> <span class="n">endDate</span> <span class="n">WRITE</span> <span \
class="n">setEndDate</span> <span class="n">NOTIFY</span> <span class="n">endDateChanged</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I also just realized that the start and end date are QStrings, and not \
QDates.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Is it easier to work with strings in QML?</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120777/diff/3/?file=330748#file330748line136" style="color: \
black; font-weight: bold; text-decoration: underline;">components/timelinemodel/timelinemodel.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px \
solid #C0C0C0;" align="right"><font size="2">136</font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q_ASSERT</span><span \
class="p">(</span><span class="n">m_level</span> <span class="o">!=</span> <span \
class="n">TimeLineModel</span><span class="o">::</span><span class="n">Year</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Has this been tested?</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This assert would be true when m_level is \
Month or Day.</p></pre> </div>
</div>
<br />
<p>- Vishesh Handa</p>
<br />
<p>On November 26th, 2014, 6:11 p.m. UTC, Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Nov. 26, 2014, 6:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mobile
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">At the moment, Baloo doesn't provide a \
timeline, which is something that we need for the activefilebrowser. So this new component, is \
introducing support for the timeline.</p> <h1 style="font-size: 100%;text-rendering: inherit;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">Notes</h1> <ul style="padding: 0;text-rendering: \
inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;"> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Baloocloud component \
contains the org.kde.baloo component inside it.The reason behind that, is that the implementation for the \
timeline is kind of terible because of its perfomance.</li> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">I have put the new component inside the \
plasma-mobile repository, for the above reason. But if the Baloo team, wants it inside the baloo repo \
then i can move it. I am fine with both approaches (keep it here or in the baloo repository.</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">If someone \
has a better idea about the implementation, the pls shoot :)</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Everything looks ok. The performance is not \
bad, except from the fact that the implementation is a bit of hackish...</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(9466447)</span></li>
<li>components/CMakeLists.txt <span style="color: grey">(536b60e)</span></li>
<li>components/timelinemodel/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>components/timelinemodel/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
<li>components/timelinemodel/timelinemodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>components/timelinemodel/timelinemodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>components/timelinemodel/timelineplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>components/timelinemodel/timelineplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120777/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6306335819531190479==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic