--===============8933457338072900994== Content-Type: multipart/alternative; boundary="===============6306335819531190479==" --===============6306335819531190479== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/#review71055 ----------------------------------------------------------- components/timelinemodel/timelinemodel.h I also just realized that the start and end date are QStrings, and not QDates. Is it easier to work with strings in QML? components/timelinemodel/timelinemodel.cpp Has this been tested? This assert would be true when m_level is Month or Day. - Vishesh Handa On Nov. 26, 2014, 6:11 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120777/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2014, 6:11 p.m.) > > > Review request for Plasma. > > > Repository: plasma-mobile > > > Description > ------- > > At the moment, Baloo doesn't provide a timeline, which is something that we need for the activefilebrowser. > So this new component, is introducing support for the timeline. > > Notes > === > > * Baloocloud component contains the org.kde.baloo component inside it.The reason behind that, is that the implementation for the timeline is kind of terible because of its perfomance. > * I have put the new component inside the plasma-mobile repository, for the above reason. But if the Baloo team, wants it inside the baloo repo then i can move it. I am fine with both approaches (keep it here or in the baloo repository. > * If someone has a better idea about the implementation, the pls shoot :) > > > > Diffs > ----- > > CMakeLists.txt 9466447 > components/CMakeLists.txt 536b60e > components/timelinemodel/CMakeLists.txt PRE-CREATION > components/timelinemodel/qmldir PRE-CREATION > components/timelinemodel/timelinemodel.h PRE-CREATION > components/timelinemodel/timelinemodel.cpp PRE-CREATION > components/timelinemodel/timelineplugin.h PRE-CREATION > components/timelinemodel/timelineplugin.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/120777/diff/ > > > Testing > ------- > > Everything looks ok. The performance is not bad, except from the fact that the implementation is a bit of hackish... > > > Thanks, > > Antonis Tsiapaliokas > > --===============6306335819531190479== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/

components/timelinemodel/timelinemodel.h (Diff revision 3)
		32	Q_PROPERTY(QString endDate READ endDate WRITE setEndDate NOTIFY endDateChanged)

I also just realized that the start and end date are QStrings, and not QDates.

Is it easier to work with strings in QML?

components/timelinemodel/timelinemodel.cpp (Diff revision 3)
		136	Q_ASSERT(m_level != TimeLineModel::Year);

Has this been tested?

This assert would be true when m_level is Month or Day.

- Vishesh Handa

On November 26th, 2014, 6:11 p.m. UTC, Antonis Tsiapaliokas wrote:

Review request for Plasma.

By Antonis Tsiapaliokas.

Updated Nov. 26, 2014, 6:11 p.m.

Repository: plasma-mobile

Description

At the moment, Baloo doesn't provide a timeline, which is something that we need for the activefilebrowser. So this new component, is introducing support for the timeline.

Notes

Baloocloud component contains the org.kde.baloo component inside it.The reason behind that, is that the implementation for the timeline is kind of terible because of its perfomance.
I have put the new component inside the plasma-mobile repository, for the above reason. But if the Baloo team, wants it inside the baloo repo then i can move it. I am fine with both approaches (keep it here or in the baloo repository.
If someone has a better idea about the implementation, the pls shoot :)

Testing

Everything looks ok. The performance is not bad, except from the fact that the implementation is a bit of hackish...

Diffs

CMakeLists.txt (9466447)
components/CMakeLists.txt (536b60e)
components/timelinemodel/CMakeLists.txt (PRE-CREATION)
components/timelinemodel/qmldir (PRE-CREATION)
components/timelinemodel/timelinemodel.h (PRE-CREATION)
components/timelinemodel/timelinemodel.cpp (PRE-CREATION)
components/timelinemodel/timelineplugin.h (PRE-CREATION)
components/timelinemodel/timelineplugin.cpp (PRE-CREATION)

--===============6306335819531190479==-- --===============8933457338072900994== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8933457338072900994==--