'Re: Review Request 121201: KRunner: Do not detect anything with a '.' as a NetworkLocation'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 121201: KRunner: Do not detect anything with a '.' as a NetworkLocation
From:       "Vishesh Handa" <me () vhanda ! in>
Date:       2014-11-25 18:10:10
Message-ID: 20141125181010.11306.28738 () probe ! kde ! org
[Download RAW message or body]

--===============8446181546002754474==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121201/#review70942
-----------------------------------------------------------

ping.

It would be nice if someone could comment on this. I cannot use Qt 5.4 right now.

- Vishesh Handa

On Nov. 21, 2014, 6:10 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121201/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2014, 6:10 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 340140
> https://bugs.kde.org/show_bug.cgi?id=340140
> 
> 
> Repository: krunner
> 
> 
> Description
> -------
> 
> One can also uses a decimal point in a calculator.
> 
> 
> Diffs
> -----
> 
> autotests/runnercontexttest.cpp ba5f6a1 
> src/runnercontext.cpp 2d6177d 
> 
> Diff: https://git.reviewboard.kde.org/r/121201/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
> 

--===============8446181546002754474==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121201/">https://git.reviewboard.kde.org/r/121201/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">ping.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">It would be nice if someone could \
comment on this. I cannot use Qt 5.4 right now.</p></pre>  <br />

<p>- Vishesh Handa</p>

<br />
<p>On November 21st, 2014, 6:10 p.m. UTC, Vishesh Handa wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Vishesh Handa.</div>

<p style="color: grey;"><i>Updated Nov. 21, 2014, 6:10 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=340140">340140</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
krunner
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">One can also uses a decimal point in a \
calculator.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/runnercontexttest.cpp <span style="color: grey">(ba5f6a1)</span></li>

 <li>src/runnercontext.cpp <span style="color: grey">(2d6177d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121201/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8446181546002754474==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 