From kde-panel-devel Tue Nov 25 18:10:10 2014 From: "Vishesh Handa" Date: Tue, 25 Nov 2014 18:10:10 +0000 To: kde-panel-devel Subject: Re: Review Request 121201: KRunner: Do not detect anything with a '.' as a NetworkLocation Message-Id: <20141125181010.11306.28738 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=141693902417326 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============9124722243477361796==" --===============9124722243477361796== Content-Type: multipart/alternative; boundary="===============8446181546002754474==" --===============8446181546002754474== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121201/#review70942 ----------------------------------------------------------- ping. It would be nice if someone could comment on this. I cannot use Qt 5.4 right now. - Vishesh Handa On Nov. 21, 2014, 6:10 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121201/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2014, 6:10 p.m.) > > > Review request for Plasma. > > > Bugs: 340140 > https://bugs.kde.org/show_bug.cgi?id=340140 > > > Repository: krunner > > > Description > ------- > > One can also uses a decimal point in a calculator. > > > Diffs > ----- > > autotests/runnercontexttest.cpp ba5f6a1 > src/runnercontext.cpp 2d6177d > > Diff: https://git.reviewboard.kde.org/r/121201/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > > --===============8446181546002754474== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121201/

ping.

It would be nice if someone could comment on this. I cannot use Qt 5.4 right now.

- Vishesh Handa

On November 21st, 2014, 6:10 p.m. UTC, Vishesh Handa wrote:

Review request for Plasma.

By Vishesh Handa.

Updated Nov. 21, 2014, 6:10 p.m.

Bugs: 340140

Repository: krunner

Description

One can also uses a decimal point in a calculator.

Diffs

autotests/runnercontexttest.cpp (ba5f6a1)
src/runnercontext.cpp (2d6177d)

View Diff

--===============8446181546002754474==-- --===============9124722243477361796== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============9124722243477361796==--