'Re: Review Request 121228: Fix minimum height in notifications'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 121228: Fix minimum height in notifications
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2014-11-25 11:04:01
Message-ID: 20141125110401.11306.18498 () probe ! kde ! org
[Download RAW message or body]

--===============3386663230407463548==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121228/
-----------------------------------------------------------

(Updated Nov. 25, 2014, 11:04 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma, Martin Klapetek and Vishesh Handa.

Bugs: 341218
    https://bugs.kde.org/show_bug.cgi?id=341218

Repository: plasma-workspace

Description
-------

This changes the bahavior from Math.max(icon, text + margins) to Math.max(icon, text) \
+ margins which should fix the layout in case the notification has no bodytext.

Diffs
-----

  applets/notifications/package/contents/ui/NotificationItem.qml 1074e63 

Diff: https://git.reviewboard.kde.org/r/121228/diff/

Testing
-------

Nope, no 5 here, hence the RR :)

Thanks,

Kai Uwe Broulik

--===============3386663230407463548==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121228/">https://git.reviewboard.kde.org/r/121228/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, Martin Klapetek and Vishesh Handa.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Nov. 25, 2014, 11:04 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=341218">341218</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This changes the bahavior from Math.max(icon, text + \
margins) to Math.max(icon, text) + margins which should fix the layout in case the \
notification has no bodytext.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Nope, no 5 here, hence the RR :)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/notifications/package/contents/ui/NotificationItem.qml <span \
style="color: grey">(1074e63)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121228/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3386663230407463548==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 