--===============2965529951881968904== Content-Type: multipart/alternative; boundary="===============3386663230407463548==" --===============3386663230407463548== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121228/ ----------------------------------------------------------- (Updated Nov. 25, 2014, 11:04 a.m.) Status ------ This change has been marked as submitted. Review request for Plasma, Martin Klapetek and Vishesh Handa. Bugs: 341218 https://bugs.kde.org/show_bug.cgi?id=341218 Repository: plasma-workspace Description ------- This changes the bahavior from Math.max(icon, text + margins) to Math.max(icon, text) + margins which should fix the layout in case the notification has no bodytext. Diffs ----- applets/notifications/package/contents/ui/NotificationItem.qml 1074e63 Diff: https://git.reviewboard.kde.org/r/121228/diff/ Testing ------- Nope, no 5 here, hence the RR :) Thanks, Kai Uwe Broulik --===============3386663230407463548== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121228/

This change has been marked as submitted.


Review request for Plasma, Martin Klapetek and Vishesh Handa.
By Kai Uwe Broulik.

Updated Nov. 25, 2014, 11:04 a.m.

Bugs: 341218
Repository: plasma-workspace

Description

This changes the bahavior from Math.max(icon, text + margins) to Math.max(icon, text) + margins which should fix the layout in case the notification has no bodytext.

Testing

Nope, no 5 here, hence the RR :)

Diffs

  • applets/notifications/package/contents/ui/NotificationItem.qml (1074e63)

View Diff

--===============3386663230407463548==-- --===============2965529951881968904== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2965529951881968904==--