'Review Request 120913: [kcms/lnf] Make a list variable const'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 120913: [kcms/lnf] Make a list variable const
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2014-10-31 11:13:27
Message-ID: 20141031111327.4239.27623 () probe ! kde ! org
[Download RAW message or body]

--===============5141472305073683053==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120913/
-----------------------------------------------------------

Review request for Plasma.

Repository: plasma-desktop

Description
-------

The dataPath variable is used in an extended for-loop as of C++11.
As the variable was not const the for loop uses the more expensive
iterators which allow modification of the list. By making the list
const it can use the better const iterator.

See http://blog.qt.digia.com/blog/2011/05/26/cpp0x-in-qt/

Diffs
-----

  kcms/lookandfeel/kcm.cpp a46774200c0c378485a474ff538294c7617ef6d2 

Diff: https://git.reviewboard.kde.org/r/120913/diff/

Testing
-------

Thanks,

Martin Gräßlin

--===============5141472305073683053==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120913/">https://git.reviewboard.kde.org/r/120913/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The dataPath variable is used in an extended for-loop as of C++11. As \
the variable was not const the for loop uses the more expensive iterators which allow \
modification of the list. By making the list const it can use the better const \
iterator.

See http://blog.qt.digia.com/blog/2011/05/26/cpp0x-in-qt/</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcms/lookandfeel/kcm.cpp <span style="color: \
grey">(a46774200c0c378485a474ff538294c7617ef6d2)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120913/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5141472305073683053==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 