[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120884: [tabbox] Get DesktopSwitcher from look and feel package
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2014-10-31 8:15:33
Message-ID: 20141031081533.4240.62979 () probe ! kde ! org
[Download RAW message or body]
--===============1138780690258351434==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120884/
-----------------------------------------------------------
(Updated Oct. 31, 2014, 8:15 a.m.)
Status
------
This change has been marked as submitted.
Review request for kwin and Plasma.
Repository: kwin
Description
-------
Like with WindowSwitcher the configured value might be for the
look and feel package and thus we should first try to locate it
from the look and feel package.
[tabbox/qml] Default desktop switcher moved to look and feel package
Diffs
-----
tabbox/tabbox.cpp aea7e11c635059850eec05045e68f661f15e7938
tabbox/tabboxhandler.cpp 44bed90f87da33fc5404b3cd8099d49edafabb5c
tabbox/qml/CMakeLists.txt e7d3b227eabf27622254ad8e50e97e6fcbec5c51
tabbox/qml/desktops/informative/contents/ui/main.qml \
54179e6b3d3c222351b1efb4e9ef276dc28df880 \
tabbox/qml/desktops/informative/metadata.desktop \
a1495d58bca63577e0d39d87193e5b44a3a7ee0e
Diff: https://git.reviewboard.kde.org/r/120884/diff/
Testing
-------
Thanks,
Martin Gräßlin
--===============1138780690258351434==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120884/">https://git.reviewboard.kde.org/r/120884/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Oct. 31, 2014, 8:15 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Like with WindowSwitcher the configured value might be \
for the look and feel package and thus we should first try to locate it
from the look and feel package.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">[tabbox/qml] Default desktop switcher moved to look \
and feel package</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tabbox/tabbox.cpp <span style="color: \
grey">(aea7e11c635059850eec05045e68f661f15e7938)</span></li>
<li>tabbox/tabboxhandler.cpp <span style="color: \
grey">(44bed90f87da33fc5404b3cd8099d49edafabb5c)</span></li>
<li>tabbox/qml/CMakeLists.txt <span style="color: \
grey">(e7d3b227eabf27622254ad8e50e97e6fcbec5c51)</span></li>
<li>tabbox/qml/desktops/informative/contents/ui/main.qml <span style="color: \
grey">(54179e6b3d3c222351b1efb4e9ef276dc28df880)</span></li>
<li>tabbox/qml/desktops/informative/metadata.desktop <span style="color: \
grey">(a1495d58bca63577e0d39d87193e5b44a3a7ee0e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120884/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1138780690258351434==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic