[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request 120892: move notification out of the way of other plasma windows
From: "Marco Martin" <notmart () gmail ! com>
Date: 2014-10-29 18:02:49
Message-ID: 20141029180249.23656.87656 () probe ! kde ! org
[Download RAW message or body]
--===============6288100808012812474==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120892/
-----------------------------------------------------------
Review request for Plasma.
Repository: plasma-workspace
Description
-------
This is an attempt to solve
https://bugs.kde.org/show_bug.cgi?id=338946
It's very crude (therefore no, i don't really like it that much)
alternatively, a second approach i was thinking to: it may be tried to find \
the actual window of the systray popup, it would probably have a better \
behavior (notifications could be moved as well when the popup opens/closes) \
finding that window reliably could be quite messy tough
Diffs
-----
applets/notifications/plugin/notificationshelper.cpp 425f0d6
Diff: https://git.reviewboard.kde.org/r/120892/diff/
Testing
-------
Thanks,
Marco Martin
--===============6288100808012812474==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120892/">https://git.reviewboard.kde.org/r/120892/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This is an attempt to solve \
https://bugs.kde.org/show_bug.cgi?id=338946</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">It's very crude (therefore no, i don't really like it that \
much)</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">alternatively, a second \
approach i was thinking to: it may be tried to find the actual window of \
the systray popup, it would probably have a better behavior (notifications \
could be moved as well when the popup opens/closes) finding that window \
reliably could be quite messy tough</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>applets/notifications/plugin/notificationshelper.cpp <span \
style="color: grey">(425f0d6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120892/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6288100808012812474==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic