From kde-panel-devel Wed Oct 29 18:02:49 2014 From: "Marco Martin" Date: Wed, 29 Oct 2014 18:02:49 +0000 To: kde-panel-devel Subject: Review Request 120892: move notification out of the way of other plasma windows Message-Id: <20141029180249.23656.87656 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=141460578209801 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8661179962175896234==" --===============8661179962175896234== Content-Type: multipart/alternative; boundary="===============6288100808012812474==" --===============6288100808012812474== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120892/ ----------------------------------------------------------- Review request for Plasma. Repository: plasma-workspace Description ------- This is an attempt to solve https://bugs.kde.org/show_bug.cgi?id=338946 It's very crude (therefore no, i don't really like it that much) alternatively, a second approach i was thinking to: it may be tried to find the actual window of the systray popup, it would probably have a better behavior (notifications could be moved as well when the popup opens/closes) finding that window reliably could be quite messy tough Diffs ----- applets/notifications/plugin/notificationshelper.cpp 425f0d6 Diff: https://git.reviewboard.kde.org/r/120892/diff/ Testing ------- Thanks, Marco Martin --===============6288100808012812474== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120892/

Review request for Plasma.

By Marco Martin.

Repository: plasma-workspace

Description

This is an attempt to solve https://bugs.kde.org/show_bug.cgi?id=338946

It's very crude (therefore no, i don't really like it that much)

alternatively, a second approach i was thinking to: it may be tried to find the actual window of the systray popup, it would probably have a better behavior (notifications could be moved as well when the popup opens/closes) finding that window reliably could be quite messy tough

Diffs

applets/notifications/plugin/notificationshelper.cpp (425f0d6)

View Diff

--===============6288100808012812474==-- --===============8661179962175896234== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8661179962175896234==--