'Re: Review Request 120352: Remove keyboard click volume setting'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 120352: Remove keyboard click volume setting
From:       "Frederik Gladhorn" <gladhorn () kde ! org>
Date:       2014-10-29 13:19:44
Message-ID: 20141029131944.23656.32206 () probe ! kde ! org
[Download RAW message or body]

--===============4242371741370505136==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120352/#review69438
-----------------------------------------------------------

I don't have much of an opinion when it comes to keyboard sounds. For virtual \
keybords this would certainly make sense, but this is about the hardware keyboard. If \
the feature never worked, then just remove it, it can always be added back and fixed \
when someone requests it.

- Frederik Gladhorn

On Sept. 28, 2014, 1:33 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120352/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2014, 1:33 p.m.)
> 
> 
> Review request for Plasma and Frederik Gladhorn.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> They keyboard daemon had a weird option for making your system make a
> short beep whenever you pressed a key.
> 
> This doesn't work and doesn't seem particularly useful.
> 
> 
> Diffs
> -----
> 
> kcms/keyboard/kcmmisc.h 411bdd2 
> kcms/keyboard/kcmmisc.cpp c63d06b 
> kcms/keyboard/kcmmiscwidget.ui 37fbaf4 
> kcms/keyboard/keyboard_hardware.cpp df5f417 
> 
> Diff: https://git.reviewboard.kde.org/r/120352/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
> 

--===============4242371741370505136==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120352/">https://git.reviewboard.kde.org/r/120352/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't have much of an opinion when it comes to keyboard sounds. For virtual keybords \
this would certainly make sense, but this is about the hardware keyboard. If the \
feature never worked, then just remove it, it can always be added back and fixed when \
someone requests it.</p></pre>  <br />

<p>- Frederik Gladhorn</p>

<br />
<p>On September 28th, 2014, 1:33 p.m. UTC, David Edmundson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Frederik Gladhorn.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated Sept. 28, 2014, 1:33 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">They keyboard daemon had a weird option for making \
your system make a short beep whenever you pressed a key.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This doesn't work and doesn't seem particularly \
useful.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcms/keyboard/kcmmisc.h <span style="color: grey">(411bdd2)</span></li>

 <li>kcms/keyboard/kcmmisc.cpp <span style="color: grey">(c63d06b)</span></li>

 <li>kcms/keyboard/kcmmiscwidget.ui <span style="color: grey">(37fbaf4)</span></li>

 <li>kcms/keyboard/keyboard_hardware.cpp <span style="color: \
grey">(df5f417)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120352/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4242371741370505136==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 