--===============7791787773503567208== Content-Type: multipart/alternative; boundary="===============4242371741370505136==" --===============4242371741370505136== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120352/#review69438 ----------------------------------------------------------- I don't have much of an opinion when it comes to keyboard sounds. For virtual keybords this would certainly make sense, but this is about the hardware keyboard. If the feature never worked, then just remove it, it can always be added back and fixed when someone requests it. - Frederik Gladhorn On Sept. 28, 2014, 1:33 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120352/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2014, 1:33 p.m.) > > > Review request for Plasma and Frederik Gladhorn. > > > Repository: plasma-desktop > > > Description > ------- > > They keyboard daemon had a weird option for making your system make a > short beep whenever you pressed a key. > > This doesn't work and doesn't seem particularly useful. > > > Diffs > ----- > > kcms/keyboard/kcmmisc.h 411bdd2 > kcms/keyboard/kcmmisc.cpp c63d06b > kcms/keyboard/kcmmiscwidget.ui 37fbaf4 > kcms/keyboard/keyboard_hardware.cpp df5f417 > > Diff: https://git.reviewboard.kde.org/r/120352/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > > --===============4242371741370505136== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120352/

I don't have much of an opinion when it comes to keyboard sounds. For virtual keybords this would certainly make sense, but this is about the hardware keyboard. If the feature never worked, then just remove it, it can always be added back and fixed when someone requests it.

- Frederik Gladhorn

On September 28th, 2014, 1:33 p.m. UTC, David Edmundson wrote:

Review request for Plasma and Frederik Gladhorn.

By David Edmundson.

Updated Sept. 28, 2014, 1:33 p.m.

Repository: plasma-desktop

Description

They keyboard daemon had a weird option for making your system make a short beep whenever you pressed a key.

This doesn't work and doesn't seem particularly useful.

Diffs

kcms/keyboard/kcmmisc.h (411bdd2)
kcms/keyboard/kcmmisc.cpp (c63d06b)
kcms/keyboard/kcmmiscwidget.ui (37fbaf4)
kcms/keyboard/keyboard_hardware.cpp (df5f417)

View Diff

--===============4242371741370505136==-- --===============7791787773503567208== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============7791787773503567208==--