'Re: Review Request 120847: [kcm/lookandfeel] Add support for changing WindowSwitcher'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: kde-panel-devel
Subject: Re: Review Request 120847: [kcm/lookandfeel] Add support for changing WindowSwitcher
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2014-10-28 14:32:17
Message-ID: 20141028143217.23655.62147 () probe ! kde ! org
[Download RAW message or body]

--===============8212493017927310206==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On Oct. 28, 2014, 3:23 p.m., Marco Martin wrote:
> > kcms/lookandfeel/kcm.cpp, line 218
> > <https://git.reviewboard.kde.org/r/120847/diff/1/?file=322480#file322480line218>
> > 
> > just out of curiosity:
> > window switchers are still shipped as separate packages (as this line suggests) \
> > or are inside the l&f package?

That's how I imagined it to work:
* default switcher is part of l&f package
* kwin's internal logic on how to load isn't changed

what I'm currently trying to figure out is how to find the theme from KWin side or \
whether it's possible to get the l&f package to install the window switcher to the \
path KWin would expect. Latter would be preffered as it would mean not adjusting KWin \
at all.

- Martin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120847/#review69289
-----------------------------------------------------------

On Oct. 28, 2014, 3 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120847/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 3 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Configuration for kwinrc and reloading KWin.
> 
> As I'm not quite sure how the mechanism works, please verify that everything needed \
> is loaded, saved, set, whatever :-) 
> 
> Diffs
> -----
> 
> kcms/lookandfeel/autotests/kcmtest.cpp 08fae140be58fc3fe105b5d8770c764f077359e5 
> kcms/lookandfeel/autotests/lookandfeel/contents/defaults \
> d16963a33a88ada2d41d966bef64a972474064bc  kcms/lookandfeel/kcm.h \
> b6b6ec99884814037ea53ca8692ed9d19a22811b  kcms/lookandfeel/kcm.cpp \
> 3ede2e05e339fbea17c504d631ccaea90728c74b  
> Diff: https://git.reviewboard.kde.org/r/120847/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

--===============8212493017927310206==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120847/">https://git.reviewboard.kde.org/r/120847/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On October 28th, 2014, 3:23 p.m. CET, <b>Marco \
Martin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/120847/diff/1/?file=322480#file322480line218" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kcms/lookandfeel/kcm.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KCMLookandFeel::load()</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">218</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="n">row</span><span class="o">-&gt;</span><span \
class="n">setData</span><span class="p">(</span><span class="o">!</span><span \
class="n">cg</span><span class="p">.</span><span class="n">readEntry</span><span \
class="p">(</span><span class="s">&quot;LayoutName&quot;</span><span \
class="p">,</span> <span class="n">QString</span><span class="p">()).</span><span \
class="n">isEmpty</span><span class="p">(),</span> <span \
class="n">HasWindowSwitcherRole</span><span class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">just \
out of curiosity: window switchers are still shipped as separate packages (as this \
line suggests) or are inside the l&amp;f package?</p></pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's how I imagined it to work: default switcher is \
part of l&amp;f package kwin's internal logic on how to load isn't changed
what I'm currently trying to figure out is how to find \
the theme from KWin side or whether it's possible to get the l&amp;f package to \
install the window switcher to the path KWin would expect. Latter would be preffered \
as it would mean not adjusting KWin at all.</pre>

<p>- Martin</p>

<br />
<p>On October 28th, 2014, 3 p.m. CET, Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Oct. 28, 2014, 3 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Configuration for kwinrc and reloading KWin.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">As I'm not quite sure how the mechanism works, please verify that \
everything needed is loaded, saved, set, whatever :-)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcms/lookandfeel/autotests/kcmtest.cpp <span style="color: \
grey">(08fae140be58fc3fe105b5d8770c764f077359e5)</span></li>

 <li>kcms/lookandfeel/autotests/lookandfeel/contents/defaults <span style="color: \
grey">(d16963a33a88ada2d41d966bef64a972474064bc)</span></li>

 <li>kcms/lookandfeel/kcm.h <span style="color: \
grey">(b6b6ec99884814037ea53ca8692ed9d19a22811b)</span></li>

 <li>kcms/lookandfeel/kcm.cpp <span style="color: \
grey">(3ede2e05e339fbea17c504d631ccaea90728c74b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120847/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8212493017927310206==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 