[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 120847: [kcm/lookandfeel] Add support for changing WindowSwitcher
From: "Marco Martin" <notmart () gmail ! com>
Date: 2014-10-28 14:23:09
Message-ID: 20141028142309.23656.29011 () probe ! kde ! org
[Download RAW message or body]
--===============2140435444224888329==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120847/#review69289
-----------------------------------------------------------
Ship it!
kcms/lookandfeel/kcm.cpp
<https://git.reviewboard.kde.org/r/120847/#comment48440>
just out of curiosity:
window switchers are still shipped as separate packages (as this line suggests) \
or are inside the l&f package?
- Marco Martin
On Ott. 28, 2014, 2 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120847/
> -----------------------------------------------------------
>
> (Updated Ott. 28, 2014, 2 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Configuration for kwinrc and reloading KWin.
>
> As I'm not quite sure how the mechanism works, please verify that everything needed \
> is loaded, saved, set, whatever :-)
>
> Diffs
> -----
>
> kcms/lookandfeel/autotests/kcmtest.cpp 08fae140be58fc3fe105b5d8770c764f077359e5
> kcms/lookandfeel/autotests/lookandfeel/contents/defaults \
> d16963a33a88ada2d41d966bef64a972474064bc kcms/lookandfeel/kcm.h \
> b6b6ec99884814037ea53ca8692ed9d19a22811b kcms/lookandfeel/kcm.cpp \
> 3ede2e05e339fbea17c504d631ccaea90728c74b
> Diff: https://git.reviewboard.kde.org/r/120847/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
--===============2140435444224888329==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120847/">https://git.reviewboard.kde.org/r/120847/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/120847/diff/1/?file=322480#file322480line218" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kcms/lookandfeel/kcm.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KCMLookandFeel::load()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">218</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">row</span><span class="o">-></span><span \
class="n">setData</span><span class="p">(</span><span class="o">!</span><span \
class="n">cg</span><span class="p">.</span><span class="n">readEntry</span><span \
class="p">(</span><span class="s">"LayoutName"</span><span \
class="p">,</span> <span class="n">QString</span><span class="p">()).</span><span \
class="n">isEmpty</span><span class="p">(),</span> <span \
class="n">HasWindowSwitcherRole</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">just \
out of curiosity: window switchers are still shipped as separate packages (as this \
line suggests) or are inside the l&f package?</p></pre> </div>
</div>
<br />
<p>- Marco Martin</p>
<br />
<p>On ottobre 28th, 2014, 2 p.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Ott. 28, 2014, 2 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Configuration for kwinrc and reloading KWin.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">As I'm not quite sure how the mechanism works, please verify that \
everything needed is loaded, saved, set, whatever :-)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/lookandfeel/autotests/kcmtest.cpp <span style="color: \
grey">(08fae140be58fc3fe105b5d8770c764f077359e5)</span></li>
<li>kcms/lookandfeel/autotests/lookandfeel/contents/defaults <span style="color: \
grey">(d16963a33a88ada2d41d966bef64a972474064bc)</span></li>
<li>kcms/lookandfeel/kcm.h <span style="color: \
grey">(b6b6ec99884814037ea53ca8692ed9d19a22811b)</span></li>
<li>kcms/lookandfeel/kcm.cpp <span style="color: \
grey">(3ede2e05e339fbea17c504d631ccaea90728c74b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120847/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2140435444224888329==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic