'Re: Review Request 120407: Show application title if SNI does not provide a tooltip'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 120407: Show application title if SNI does not provide a tooltip
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2014-09-28 17:43:23
Message-ID: 20140928174323.15675.32813 () probe ! kde ! org
[Download RAW message or body]

--===============4988463856166303448==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120407/
-----------------------------------------------------------

(Updated Sept. 28, 2014, 5:43 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Bugs: 337710
    https://bugs.kde.org/show_bug.cgi?id=337710

Repository: plasma-workspace

Description
-------

Since the SNI spec does not requires you to provide a tooltip, this patch makes the \
tooltip show the application icon and name in case no tooltip is provided. This also \
restores Plasma 4.x behavior afaict.

Diffs
-----

  applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.cpp 14458e9 

Diff: https://git.reviewboard.kde.org/r/120407/diff/

Testing
-------

- Plugged in and out SD card, devicenotifier updated its icon accordingly
- Mousewheel'd kmix, tooltip text was updated properly
- Steam tooltip now has icon and text

File Attachments
----------------

Steam tooltip
  https://git.reviewboard.kde.org/media/uploaded/files/2014/09/28/ebd6683d-b47b-4c06-9cc2-afbbfd8da57a__steamtooltip.png

Thanks,

Kai Uwe Broulik

--===============4988463856166303448==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120407/">https://git.reviewboard.kde.org/r/120407/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Sept. 28, 2014, 5:43 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=337710">337710</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Since the SNI spec does not requires you to provide a \
tooltip, this patch makes the tooltip show the application icon and name in case no \
tooltip is provided. This also restores Plasma 4.x behavior afaict.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Plugged in and out SD \
card, devicenotifier updated its icon accordingly</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Mousewheel'd kmix, tooltip text was updated properly</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Steam tooltip now has icon and text</li> </ul></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.cpp <span \
style="color: grey">(14458e9)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120407/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/28/ebd6683d-b47b-4c06-9cc2-afbbfd8da57a__steamtooltip.png">Steam \
tooltip</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4988463856166303448==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 