--===============2573705647071843617== Content-Type: multipart/alternative; boundary="===============4988463856166303448==" --===============4988463856166303448== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120407/ ----------------------------------------------------------- (Updated Sept. 28, 2014, 5:43 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Bugs: 337710 https://bugs.kde.org/show_bug.cgi?id=337710 Repository: plasma-workspace Description ------- Since the SNI spec does not requires you to provide a tooltip, this patch makes the tooltip show the application icon and name in case no tooltip is provided. This also restores Plasma 4.x behavior afaict. Diffs ----- applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.cpp 14458e9 Diff: https://git.reviewboard.kde.org/r/120407/diff/ Testing ------- - Plugged in and out SD card, devicenotifier updated its icon accordingly - Mousewheel'd kmix, tooltip text was updated properly - Steam tooltip now has icon and text File Attachments ---------------- Steam tooltip https://git.reviewboard.kde.org/media/uploaded/files/2014/09/28/ebd6683d-b47b-4c06-9cc2-afbbfd8da57a__steamtooltip.png Thanks, Kai Uwe Broulik --===============4988463856166303448== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120407/

This change has been marked as submitted.

Review request for Plasma.

By Kai Uwe Broulik.

Updated Sept. 28, 2014, 5:43 p.m.

Bugs: 337710

Repository: plasma-workspace

Description

Since the SNI spec does not requires you to provide a tooltip, this patch makes the tooltip show the application icon and name in case no tooltip is provided. This also restores Plasma 4.x behavior afaict.

Testing


Plugged in and out SD card, devicenotifier updated its icon accordingly
Mousewheel'd kmix, tooltip text was updated properly
Steam tooltip now has icon and text

Diffs

applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.cpp (14458e9)

View Diff

File Attachments

Steam tooltip

--===============4988463856166303448==-- --===============2573705647071843617== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2573705647071843617==--