'Re: Review Request 120396: Port the PowerDevil runner'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 120396: Port the PowerDevil runner
From:       "Hrvoje Senjan" <hrvoje.senjan () gmail ! com>
Date:       2014-09-28 17:40:23
Message-ID: 20140928174023.15676.82168 () probe ! kde ! org
[Download RAW message or body]

--===============0804442042345576078==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120396/
-----------------------------------------------------------

(Updated Sept. 28, 2014, 5:40 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma and Vishesh Handa.

Repository: plasma-workspace

Description
-------

i really don't suspend as i used to - otherwise i'd ported it already :D for me most \
used runner other than service one in 4.x plasma. kdelibs4support is needed due to \
Solid/Powermanagement usage

Diffs
-----

  runners/CMakeLists.txt 20488a8 
  runners/powerdevil/CMakeLists.txt 55ae806 
  runners/powerdevil/PowerDevilRunner.h f070701 
  runners/powerdevil/PowerDevilRunner.cpp 7c27d9c 

Diff: https://git.reviewboard.kde.org/r/120396/diff/

Testing
-------

builds, 'sleep' appears in results and correctly suspends.
2 caveats:
a) (not limited to this runner) it isn't enabled by default somehow
b) the 'sleep' result is IMO too low on list, maybe Vishesh knows why

Thanks,

Hrvoje Senjan

--===============0804442042345576078==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120396/">https://git.reviewboard.kde.org/r/120396/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Vishesh Handa.</div>
<div>By Hrvoje Senjan.</div>

<p style="color: grey;"><i>Updated Sept. 28, 2014, 5:40 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">i really don't suspend as i used to - otherwise i'd \
ported it already :D for me most used runner other than service one in 4.x plasma. \
kdelibs4support is needed due to Solid/Powermanagement usage</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">builds, 'sleep' appears in results and correctly \
suspends.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> 2 caveats:<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> a) (not limited to \
this runner) it isn't enabled by default somehow<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> b) the 'sleep' result \
is IMO too low on list, maybe Vishesh knows why</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>runners/CMakeLists.txt <span style="color: grey">(20488a8)</span></li>

 <li>runners/powerdevil/CMakeLists.txt <span style="color: \
grey">(55ae806)</span></li>

 <li>runners/powerdevil/PowerDevilRunner.h <span style="color: \
grey">(f070701)</span></li>

 <li>runners/powerdevil/PowerDevilRunner.cpp <span style="color: \
grey">(7c27d9c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120396/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0804442042345576078==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 