From kde-panel-devel Sun Sep 28 17:40:23 2014 From: "Hrvoje Senjan" Date: Sun, 28 Sep 2014 17:40:23 +0000 To: kde-panel-devel Subject: Re: Review Request 120396: Port the PowerDevil runner Message-Id: <20140928174023.15676.82168 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=141192604501109 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8540666861181732913==" --===============8540666861181732913== Content-Type: multipart/alternative; boundary="===============0804442042345576078==" --===============0804442042345576078== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120396/ ----------------------------------------------------------- (Updated Sept. 28, 2014, 5:40 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma and Vishesh Handa. Repository: plasma-workspace Description ------- i really don't suspend as i used to - otherwise i'd ported it already :D for me most used runner other than service one in 4.x plasma. kdelibs4support is needed due to Solid/Powermanagement usage Diffs ----- runners/CMakeLists.txt 20488a8 runners/powerdevil/CMakeLists.txt 55ae806 runners/powerdevil/PowerDevilRunner.h f070701 runners/powerdevil/PowerDevilRunner.cpp 7c27d9c Diff: https://git.reviewboard.kde.org/r/120396/diff/ Testing ------- builds, 'sleep' appears in results and correctly suspends. 2 caveats: a) (not limited to this runner) it isn't enabled by default somehow b) the 'sleep' result is IMO too low on list, maybe Vishesh knows why Thanks, Hrvoje Senjan --===============0804442042345576078== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120396/

This change has been marked as submitted.

Review request for Plasma and Vishesh Handa.
By Hrvoje Senjan.

Updated Sept. 28, 2014, 5:40 p.m.

Repository: plasma-workspace

Description 

i really don't suspend as i used to - otherwise i'd ported it already :D for me most used runner other than service one in 4.x plasma. kdelibs4support is needed due to Solid/Powermanagement usage

Testing 

builds, 'sleep' appears in results and correctly suspends.

2 caveats:

a) (not limited to this runner) it isn't enabled by default somehow

b) the 'sleep' result is IMO too low on list, maybe Vishesh knows why

Diffs

  • runners/CMakeLists.txt (20488a8)
  • runners/powerdevil/CMakeLists.txt (55ae806)
  • runners/powerdevil/PowerDevilRunner.h (f070701)
  • runners/powerdevil/PowerDevilRunner.cpp (7c27d9c)

View Diff
--===============0804442042345576078==-- --===============8540666861181732913== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8540666861181732913==--