'Re: Review Request 120037: Implement scientific notation for the calculator'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 120037: Implement scientific notation for the calculator
From:       Martin Yrjölä <martin.yrjola () gmail ! com>
Date:       2014-09-02 18:51:16
Message-ID: 20140902185116.11809.75532 () probe ! kde ! org
[Download RAW message or body]

--===============5465030886758575599==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120037/
-----------------------------------------------------------

(Updated Sept. 2, 2014, 6:51 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma and David Edmundson.

Repository: kdeplasma-addons

Description
-------

Also solves the problem with the result not fitting in the display

Diffs
-----

  applets/calculator/package/contents/ui/calculator.qml \
7cb16486513cf5813612dddf0286ae7af7d48a7d 

Diff: https://git.reviewboard.kde.org/r/120037/diff/

Testing
-------

Works well, except it doesn't automatically fit the text when resizing the plasmoid.

File Attachments
----------------

Screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2014/09/02/56a989ba-7d45-48d5-b3ab-75ca019a42dc__2014-09-02-201114_198x418_scrot.png

Thanks,

Martin Yrjölä

--===============5465030886758575599==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120037/">https://git.reviewboard.kde.org/r/120037/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and David Edmundson.</div>
<div>By Martin Yrjölä.</div>

<p style="color: grey;"><i>Updated Sept. 2, 2014, 6:51 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Also solves the problem with the result not fitting in \
the display</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works well, except it doesn't automatically fit the \
text when resizing the plasmoid.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/calculator/package/contents/ui/calculator.qml <span style="color: \
grey">(7cb16486513cf5813612dddf0286ae7af7d48a7d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120037/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/02/56a989ba \
-7d45-48d5-b3ab-75ca019a42dc__2014-09-02-201114_198x418_scrot.png">Screenshot</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5465030886758575599==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 