'Re: Review Request 117499: Fix showing the user switchting dialog a second time in the screen locker'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 117499: Fix showing the user switchting dialog a second time in the screen locker
From:       "Felix Geyer" <debfx-kde () fobos ! de>
Date:       2014-09-02 18:49:38
Message-ID: 20140902184938.11809.67089 () probe ! kde ! org
[Download RAW message or body]

--===============4625413617159347753==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117499/
-----------------------------------------------------------

(Updated Sept. 2, 2014, 6:49 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma, David Edmundson, Thomas Lübking, and Wolfgang Bauer.

Bugs: 331761
    http://bugs.kde.org/show_bug.cgi?id=331761

Repository: kde-workspace

Description
-------

The user switichting dialog from the screen locker is destroyed when the cancel \
button is pressed. As a result you can't open it again.

The screen locker uses a PlasmaComponents.PageStack to show the password input and \
user switching dialogs. When a dialog is popped from the stack it is destroyed by \
PageStack.

This change fixes this by creating a new instance of userSessionsUI before it is \
pushed to the stack. Additionally the switchUserEnabled property is set once when the \
screen locker is created as userSessionsUIInstance doesn't always exist. 

Diffs
-----

  ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/main.qml \
0d3c7d5 

Diff: https://git.reviewboard.kde.org/r/117499/diff/

Testing
-------

- Lock the screen
- Press "Switch user"
- Press "Cancel"
- With this patch the "Switch user" button is visible and functional.

Thanks,

Felix Geyer

--===============4625413617159347753==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/117499/">https://git.reviewboard.kde.org/r/117499/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, David Edmundson, Thomas Lübking, and Wolfgang \
Bauer.</div> <div>By Felix Geyer.</div>

<p style="color: grey;"><i>Updated Sept. 2, 2014, 6:49 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=331761">331761</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The user switichting dialog from the screen locker is \
destroyed when the cancel button is pressed.<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> As a result you can't \
open it again.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The screen locker uses a \
PlasmaComponents.PageStack to show the password input and user switching dialogs.<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> When a dialog is popped from the stack it is destroyed by PageStack.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This change fixes this by creating a new instance of \
userSessionsUI before it is pushed to the stack.<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> Additionally the \
switchUserEnabled property is set once when the screen locker is created as \
userSessionsUIInstance<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> doesn't always exist. </p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">- Lock the screen<br style="padding: 0;text-rendering: \
                inherit;margin: 0;line-height: inherit;white-space: normal;" />
- Press "Switch user"<br style="padding: 0;text-rendering: inherit;margin: \
                0;line-height: inherit;white-space: normal;" />
- Press "Cancel"<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
                inherit;white-space: normal;" />
- With this patch the "Switch user" button is visible and functional.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/main.qml \
<span style="color: grey">(0d3c7d5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/117499/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4625413617159347753==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 