'Re: Review Request 120002: Systemloadviewer: settings window redesign'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 120002: Systemloadviewer: settings window redesign
From:       Martin Yrjölä <martin.yrjola () gmail ! com>
Date:       2014-08-30 13:34:13
Message-ID: 20140830133413.14966.28812 () probe ! kde ! org
[Download RAW message or body]

--===============0873032652653480313==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120002/
-----------------------------------------------------------

(Updated Aug. 30, 2014, 1:34 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma and David Edmundson.

Repository: kdeplasma-addons

Description
-------

More polish by courtesy of the VDG.

Diffs
-----

  applets/systemloadviewer/package/contents/config/config.qml \
570cc77ece3ed0bf84d89e45426773954f95d409   \
applets/systemloadviewer/package/contents/config/main.xml \
5e38045eb369e029564abf973827eb84534eb9f4   \
applets/systemloadviewer/package/contents/ui/ColorPicker.qml \
1b3c88233da75b9d001a0159dd4298d41f7d307c   \
applets/systemloadviewer/package/contents/ui/ColorSettings.qml PRE-CREATION   \
applets/systemloadviewer/package/contents/ui/GeneralSettings.qml \
fd719d5f2afed8c630fd6a1281f6ddda674b60c2   \
applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml \
9e101f8fd68602495366c0dc8226927a572e0267 

Diff: https://git.reviewboard.kde.org/r/120002/diff/

Testing
-------

Mostly cosmetic changes, but I tested that the options does still work.

File Attachments
----------------

General settings
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/30/7ed9b718-93bd-4936-98dd-7a58b8b51128__2014-08-30-142153_361x169_scrot.png
 Color settings with enabled manual color settings
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/30/8e2367fd-9f44-4bd2-87fe-df5ffbd746be__2014-08-30-143838_256x304_scrot.png
 Color settings with disabled manual color settings
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/30/8399a4e1-7fa0-4369-ae30-cadbe455d2bb__2014-08-30-143853_254x304_scrot.png

Thanks,

Martin Yrjölä

--===============0873032652653480313==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120002/">https://git.reviewboard.kde.org/r/120002/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and David Edmundson.</div>
<div>By Martin Yrjölä.</div>

<p style="color: grey;"><i>Updated Aug. 30, 2014, 1:34 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">More polish by courtesy of the VDG.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Mostly cosmetic changes, but I tested that the options \
does still work.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/systemloadviewer/package/contents/config/config.qml <span style="color: \
grey">(570cc77ece3ed0bf84d89e45426773954f95d409)</span></li>

 <li>applets/systemloadviewer/package/contents/config/main.xml <span style="color: \
grey">(5e38045eb369e029564abf973827eb84534eb9f4)</span></li>

 <li>applets/systemloadviewer/package/contents/ui/ColorPicker.qml <span style="color: \
grey">(1b3c88233da75b9d001a0159dd4298d41f7d307c)</span></li>

 <li>applets/systemloadviewer/package/contents/ui/ColorSettings.qml <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>applets/systemloadviewer/package/contents/ui/GeneralSettings.qml <span \
style="color: grey">(fd719d5f2afed8c630fd6a1281f6ddda674b60c2)</span></li>

 <li>applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml <span \
style="color: grey">(9e101f8fd68602495366c0dc8226927a572e0267)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120002/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/30/7ed9b718-93bd-4936-98dd-7a58b8b51128__2014-08-30-142153_361x169_scrot.png">General \
settings</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/30/8e2367fd-9f44-4bd2-87fe-df5ffbd746be__2014-08-30-143838_256x304_scrot.png">Color \
settings with enabled manual color settings</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/30/8399a4e1-7fa0-4369-ae30-cadbe455d2bb__2014-08-30-143853_254x304_scrot.png">Color \
settings with disabled manual color settings</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0873032652653480313==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 