From kde-panel-devel Sat Aug 30 13:34:13 2014 From: =?utf-8?b?TWFydGluIFlyasO2bMOk?= Date: Sat, 30 Aug 2014 13:34:13 +0000 To: kde-panel-devel Subject: Re: Review Request 120002: Systemloadviewer: settings window redesign Message-Id: <20140830133413.14966.28812 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=140940567120316 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0990592375598838252==" --===============0990592375598838252== Content-Type: multipart/alternative; boundary="===============0873032652653480313==" --===============0873032652653480313== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120002/ ----------------------------------------------------------- (Updated Aug. 30, 2014, 1:34 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma and David Edmundson. Repository: kdeplasma-addons Description ------- More polish by courtesy of the VDG. Diffs ----- applets/systemloadviewer/package/contents/config/config.qml 570cc77ece3ed0bf84d89e45426773954f95d409 applets/systemloadviewer/package/contents/config/main.xml 5e38045eb369e029564abf973827eb84534eb9f4 applets/systemloadviewer/package/contents/ui/ColorPicker.qml 1b3c88233da75b9d001a0159dd4298d41f7d307c applets/systemloadviewer/package/contents/ui/ColorSettings.qml PRE-CREATION applets/systemloadviewer/package/contents/ui/GeneralSettings.qml fd719d5f2afed8c630fd6a1281f6ddda674b60c2 applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 9e101f8fd68602495366c0dc8226927a572e0267 Diff: https://git.reviewboard.kde.org/r/120002/diff/ Testing ------- Mostly cosmetic changes, but I tested that the options does still work. File Attachments ---------------- General settings https://git.reviewboard.kde.org/media/uploaded/files/2014/08/30/7ed9b718-93bd-4936-98dd-7a58b8b51128__2014-08-30-142153_361x169_scrot.png Color settings with enabled manual color settings https://git.reviewboard.kde.org/media/uploaded/files/2014/08/30/8e2367fd-9f44-4bd2-87fe-df5ffbd746be__2014-08-30-143838_256x304_scrot.png Color settings with disabled manual color settings https://git.reviewboard.kde.org/media/uploaded/files/2014/08/30/8399a4e1-7fa0-4369-ae30-cadbe455d2bb__2014-08-30-143853_254x304_scrot.png Thanks, Martin Yrjölä --===============0873032652653480313== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120002/

This change has been marked as submitted.

Review request for Plasma and David Edmundson.
By Martin Yrjölä.

Updated Aug. 30, 2014, 1:34 p.m.

Repository: kdeplasma-addons

Description 

More polish by courtesy of the VDG.

Testing 

Mostly cosmetic changes, but I tested that the options does still work.

Diffs

  • applets/systemloadviewer/package/contents/config/config.qml (570cc77ece3ed0bf84d89e45426773954f95d409)
  • applets/systemloadviewer/package/contents/config/main.xml (5e38045eb369e029564abf973827eb84534eb9f4)
  • applets/systemloadviewer/package/contents/ui/ColorPicker.qml (1b3c88233da75b9d001a0159dd4298d41f7d307c)
  • applets/systemloadviewer/package/contents/ui/ColorSettings.qml (PRE-CREATION)
  • applets/systemloadviewer/package/contents/ui/GeneralSettings.qml (fd719d5f2afed8c630fd6a1281f6ddda674b60c2)
  • applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml (9e101f8fd68602495366c0dc8226927a572e0267)

View Diff

File Attachments

  • General settings
  • Color settings with enabled manual color settings
  • Color settings with disabled manual color settings
    		•
    --===============0873032652653480313==-- --===============0990592375598838252== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0990592375598838252==--