[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 119988: Package structure cleanups
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2014-08-29 12:00:25
Message-ID: 20140829120025.11204.13210 () probe ! kde ! org
[Download RAW message or body]
--===============7225262675144130181==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119988/#review65481
-----------------------------------------------------------
src/plasma/packagestructure.h
<https://git.reviewboard.kde.org/r/119988/#comment45738>
would removing a #define count as a SIC?
- David Edmundson
On Aug. 29, 2014, 11:51 a.m., Aaron J. Seigo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119988/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2014, 11:51 a.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> This patch set does the following:
>
> * tidy up the data engine plugin loading code
> * make PackageStructure plugins use the json method as with DataEngines
> * remove ShellPackage; it moves to live with plasmashell (review #119989)
>
> The goal here is to get rid of the plasmaquick library as much as possible. It was \
> unnecessary in the first place since PackageStructure supports plugins. The only \
> potentially controversial change here is to move PackageStructure to use the \
> json-based plugin loading. That seems to be the more modern approach, but plugin \
> loading in libplasma is currently a mix of the old and the new. As PackageStructure \
> changed API in plasma-framework, meaning any existing plugins from 4.x would need \
> updating anyways, this seems a safe enough change to make as it should impact \
> exactly zero plugins out there currently.
>
> Diffs
> -----
>
> src/plasma/packagestructure.h fb32c22a6e7df1528b3d7a5b30b94c60a85a93e3
> src/plasma/pluginloader.cpp d2ba5ca2d3a96fe6f1ce26be41df3b0954b924df
> src/plasma/private/packages.cpp 5eb6f0021392257634dfd958c940b2945989e48b
> src/plasma/private/packages_p.h 0833a4ed1b5704efffccade5e52589878e8b4957
> src/plasmaquick/CMakeLists.txt 1ed7c67efcba0e6dbef1ff929b176090786503de
> src/plasmaquick/private/packages.h 7498832d0537611903c13e544db6486bab163dd3
> src/plasmaquick/private/packages.cpp 52758482230d271712e4bb3b6d33f8fdeaa848a8
> src/plasmaquick/shellpluginloader.h 6c56e5f7b269c3af7587a58cbe104468a2c679c4
> src/plasmaquick/shellpluginloader.cpp 2824760e6f64a694bd14b46d2f80151304e3e4d3
> src/plasma/dataengine.h d87a6f8361c892a249374a5c9da7e84836195156
> src/plasma/package.cpp 6ad332167bb83c2f794f9f5d059e9f369ad33841
>
> Diff: https://git.reviewboard.kde.org/r/119988/diff/
>
>
> Testing
> -------
>
> Ran a full Plasma Desktop session.
>
>
> Thanks,
>
> Aaron J. Seigo
>
>
--===============7225262675144130181==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119988/">https://git.reviewboard.kde.org/r/119988/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119988/diff/1/?file=308188#file308188line99" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/plasma/packagestructure.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">private:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">98</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#define \
K_EXPORT_PLASMA_PACKAGE(libname, classname) \</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">99</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">would \
removing a #define count as a SIC?</p></pre> </div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On August 29th, 2014, 11:51 a.m. UTC, Aaron J. Seigo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Aaron J. Seigo.</div>
<p style="color: grey;"><i>Updated Aug. 29, 2014, 11:51 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch set does the following:</p> <ul \
style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">tidy up the data engine plugin loading \
code</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">make PackageStructure plugins use the json method as \
with DataEngines</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">remove ShellPackage; it moves to live \
with plasmashell (review #119989)</li> </ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The goal here is to get rid of the plasmaquick library \
as much as possible. It was unnecessary in the first place since PackageStructure \
supports plugins. The only potentially controversial change here is to move \
PackageStructure to use the json-based plugin loading. That seems to be the more \
modern approach, but plugin loading in libplasma is currently a mix of the old and \
the new. As PackageStructure changed API in plasma-framework, meaning any existing \
plugins from 4.x would need updating anyways, this seems a safe enough change to make \
as it should impact exactly zero plugins out there currently.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ran a full Plasma Desktop session.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasma/packagestructure.h <span style="color: \
grey">(fb32c22a6e7df1528b3d7a5b30b94c60a85a93e3)</span></li>
<li>src/plasma/pluginloader.cpp <span style="color: \
grey">(d2ba5ca2d3a96fe6f1ce26be41df3b0954b924df)</span></li>
<li>src/plasma/private/packages.cpp <span style="color: \
grey">(5eb6f0021392257634dfd958c940b2945989e48b)</span></li>
<li>src/plasma/private/packages_p.h <span style="color: \
grey">(0833a4ed1b5704efffccade5e52589878e8b4957)</span></li>
<li>src/plasmaquick/CMakeLists.txt <span style="color: \
grey">(1ed7c67efcba0e6dbef1ff929b176090786503de)</span></li>
<li>src/plasmaquick/private/packages.h <span style="color: \
grey">(7498832d0537611903c13e544db6486bab163dd3)</span></li>
<li>src/plasmaquick/private/packages.cpp <span style="color: \
grey">(52758482230d271712e4bb3b6d33f8fdeaa848a8)</span></li>
<li>src/plasmaquick/shellpluginloader.h <span style="color: \
grey">(6c56e5f7b269c3af7587a58cbe104468a2c679c4)</span></li>
<li>src/plasmaquick/shellpluginloader.cpp <span style="color: \
grey">(2824760e6f64a694bd14b46d2f80151304e3e4d3)</span></li>
<li>src/plasma/dataengine.h <span style="color: \
grey">(d87a6f8361c892a249374a5c9da7e84836195156)</span></li>
<li>src/plasma/package.cpp <span style="color: \
grey">(6ad332167bb83c2f794f9f5d059e9f369ad33841)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119988/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7225262675144130181==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic