[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request 119989: PackageStructure plugins in plasma-workspaces
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2014-08-29 11:53:40
Message-ID: 20140829115340.11205.65878 () probe ! kde ! org
[Download RAW message or body]
--===============2044481964095932406==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119989/
-----------------------------------------------------------
Review request for Plasma.
Repository: plasma-workspace
Description
-------
This patchset introduces the use of PackageStructure plugins to plasma-workspace, \
allowing the removal of ShellPluginLoader everywhere. It also fixes some strange use \
of PackageStructure in the share DataEngine and updates that PackageStructure to use \
the JSON-based loading.
With this changeset Plasma/Shell, Plasma/LookAndFeel and Plasma/Wallpaper are all \
plugins and accessible from everywhere that needs them via Plasma::PluginLoader.
Diffs
-----
dataengines/share/share_package.cpp 13f41def3abd5ccf57b8745e3fd6956d10377a7a
dataengines/share/shareprovider.h c9159cdde6a858fbdca57ad7c5aa258028fd9ac3
dataengines/share/shareprovider.cpp fd1812fa1263cdf9df7d4340c681a63f8455ce07
shell/packageplugins/shell/shellpackage.h PRE-CREATION
shell/packageplugins/shell/shellpackage.cpp PRE-CREATION
shell/packageplugins/wallpaper/CMakeLists.txt PRE-CREATION
ksmserver/screenlocker/greeter/greeterapp.cpp \
92e839091412585dddc369d5a4a3beace39e92ae ksmserver/shellpluginloader.h \
6f13d493a800a7479711ef3549cfd9362a593778 ksmserver/shutdowndlg.cpp \
b4e59a387e5bf857db6314cf1b879e6a775e9f99 lookandfeelaccess/lookandfeelaccess.cpp \
474e06d7b189fc368d1f9ba45426ea30392e2a71 lookandfeelaccess/shellpluginloader.h \
9c0f62412eac4d1ad03c681325852d9efe25ccda plasma-windowed/main.cpp \
4e9263aad9736b93dc00e7fef74db54b39456cb6 plasma-windowed/plasma-windowed.desktop \
a462867d8a680d714490a0783f85902e373f26a1 \
plasma-windowed/plasmaquick/shellpluginloader.h \
ea0755e4abe841e33777d89cb12a5e689161e51b plasma-windowed/plasmawindowedcorona.cpp \
23bc60384ffbffec90b9cae5ddb6d35b1aaa1fc0 shell/CMakeLists.txt \
d67be9782de1faa9890bf85b8b2b517e15f12812 shell/main.cpp \
bb63bdc85ff2a003fa4a5c4e2320383db98da087 shell/osd.cpp \
961c9ca3974337553bcefc1fc2c06222da9114e1 shell/packageplugins/CMakeLists.txt \
PRE-CREATION shell/packageplugins/layouttemplate/CMakeLists.txt PRE-CREATION
shell/packageplugins/layouttemplate/layouttemplate.h PRE-CREATION
shell/packageplugins/layouttemplate/layouttemplate.cpp PRE-CREATION
shell/packageplugins/layouttemplate/plasma-packagestructure-layouttemplate.desktop \
PRE-CREATION shell/packageplugins/lookandfeel/CMakeLists.txt PRE-CREATION
shell/packageplugins/lookandfeel/lookandfeel.h PRE-CREATION
shell/packageplugins/lookandfeel/lookandfeel.cpp PRE-CREATION
shell/packageplugins/lookandfeel/plasma-packagestructure-lookandfeel.desktop \
PRE-CREATION shell/packageplugins/packages.h PRE-CREATION
shell/packageplugins/packages.cpp PRE-CREATION
shell/packageplugins/shell/CMakeLists.txt PRE-CREATION
shell/packageplugins/shell/Messages.sh PRE-CREATION
shell/packageplugins/shell/plasma-packagestructure-plasma-shell.desktop \
PRE-CREATION dataengines/share/share_package.h
dataengines/share/CMakeLists.txt 3d67b137f9a3e37453b8890d0d3c73e6469bae38
dataengines/share/data/CMakeLists.txt e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
dataengines/share/data/plasma-packagestructure-share.desktop
dataengines/share/packagestructure/CMakeLists.txt PRE-CREATION
dataengines/share/plugin_share_package.cpp c4e2f23f7a65ddc67a94c60dffa3f71701a46b8b \
shell/packageplugins/wallpaper/plasma-packagestructure-wallpaper.desktop \
PRE-CREATION shell/packageplugins/wallpaper/wallpaper.h PRE-CREATION
shell/packageplugins/wallpaper/wallpaper.cpp PRE-CREATION
shell/plasmaquick/shellpluginloader.h ea0755e4abe841e33777d89cb12a5e689161e51b
shell/shellcorona.h d559fcdc99c0066d552e013d3fea249147f50b5f
shell/shellcorona.cpp 84442ae60cf0f576a077e770ceae82a17721a456
dataengines/share/shareservice.h 5fb533d06fc74a52c33e0c8e1052ec93ffc4e11f
dataengines/share/shareservice.cpp 8442b6634e5e55f8717b9684dd41839df8d3d677
krunner/main.cpp 4d8cc31ff4d78c2daa0f9a6af247b3bd1c317ffa
krunner/shellpluginloader.h 9c0f62412eac4d1ad03c681325852d9efe25ccda
krunner/view.cpp 0d986e845e3b9821ef39a874d431a087e2390e8a
Diff: https://git.reviewboard.kde.org/r/119989/diff/
Testing
-------
Ran a full Plasma Desktop session with these changes.
Thanks,
Aaron J. Seigo
--===============2044481964095932406==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119989/">https://git.reviewboard.kde.org/r/119989/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aaron J. Seigo.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patchset introduces the use of PackageStructure \
plugins to plasma-workspace, allowing the removal of ShellPluginLoader everywhere. It \
also fixes some strange use of PackageStructure in the share DataEngine and updates \
that PackageStructure to use the JSON-based loading.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With \
this changeset Plasma/Shell, Plasma/LookAndFeel and Plasma/Wallpaper are all plugins \
and accessible from everywhere that needs them via Plasma::PluginLoader.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ran a full Plasma Desktop session with these \
changes.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dataengines/share/share_package.cpp <span style="color: \
grey">(13f41def3abd5ccf57b8745e3fd6956d10377a7a)</span></li>
<li>dataengines/share/shareprovider.h <span style="color: \
grey">(c9159cdde6a858fbdca57ad7c5aa258028fd9ac3)</span></li>
<li>dataengines/share/shareprovider.cpp <span style="color: \
grey">(fd1812fa1263cdf9df7d4340c681a63f8455ce07)</span></li>
<li>shell/packageplugins/shell/shellpackage.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/shell/shellpackage.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/wallpaper/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: \
grey">(92e839091412585dddc369d5a4a3beace39e92ae)</span></li>
<li>ksmserver/shellpluginloader.h <span style="color: \
grey">(6f13d493a800a7479711ef3549cfd9362a593778)</span></li>
<li>ksmserver/shutdowndlg.cpp <span style="color: \
grey">(b4e59a387e5bf857db6314cf1b879e6a775e9f99)</span></li>
<li>lookandfeelaccess/lookandfeelaccess.cpp <span style="color: \
grey">(474e06d7b189fc368d1f9ba45426ea30392e2a71)</span></li>
<li>lookandfeelaccess/shellpluginloader.h <span style="color: \
grey">(9c0f62412eac4d1ad03c681325852d9efe25ccda)</span></li>
<li>plasma-windowed/main.cpp <span style="color: \
grey">(4e9263aad9736b93dc00e7fef74db54b39456cb6)</span></li>
<li>plasma-windowed/plasma-windowed.desktop <span style="color: \
grey">(a462867d8a680d714490a0783f85902e373f26a1)</span></li>
<li>plasma-windowed/plasmaquick/shellpluginloader.h <span style="color: \
grey">(ea0755e4abe841e33777d89cb12a5e689161e51b)</span></li>
<li>plasma-windowed/plasmawindowedcorona.cpp <span style="color: \
grey">(23bc60384ffbffec90b9cae5ddb6d35b1aaa1fc0)</span></li>
<li>shell/CMakeLists.txt <span style="color: \
grey">(d67be9782de1faa9890bf85b8b2b517e15f12812)</span></li>
<li>shell/main.cpp <span style="color: \
grey">(bb63bdc85ff2a003fa4a5c4e2320383db98da087)</span></li>
<li>shell/osd.cpp <span style="color: \
grey">(961c9ca3974337553bcefc1fc2c06222da9114e1)</span></li>
<li>shell/packageplugins/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/layouttemplate/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/layouttemplate/layouttemplate.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/layouttemplate/layouttemplate.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/layouttemplate/plasma-packagestructure-layouttemplate.desktop \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/lookandfeel/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/lookandfeel/lookandfeel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/lookandfeel/lookandfeel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/lookandfeel/plasma-packagestructure-lookandfeel.desktop \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/packages.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/packages.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/shell/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/shell/Messages.sh <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/shell/plasma-packagestructure-plasma-shell.desktop <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>dataengines/share/share_package.h <span style="color: grey">()</span></li>
<li>dataengines/share/CMakeLists.txt <span style="color: \
grey">(3d67b137f9a3e37453b8890d0d3c73e6469bae38)</span></li>
<li>dataengines/share/data/CMakeLists.txt <span style="color: \
grey">(e69de29bb2d1d6434b8b29ae775ad8c2e48c5391)</span></li>
<li>dataengines/share/data/plasma-packagestructure-share.desktop <span style="color: \
grey">()</span></li>
<li>dataengines/share/packagestructure/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>dataengines/share/plugin_share_package.cpp <span style="color: \
grey">(c4e2f23f7a65ddc67a94c60dffa3f71701a46b8b)</span></li>
<li>shell/packageplugins/wallpaper/plasma-packagestructure-wallpaper.desktop <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/wallpaper/wallpaper.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shell/packageplugins/wallpaper/wallpaper.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>shell/plasmaquick/shellpluginloader.h <span style="color: \
grey">(ea0755e4abe841e33777d89cb12a5e689161e51b)</span></li>
<li>shell/shellcorona.h <span style="color: \
grey">(d559fcdc99c0066d552e013d3fea249147f50b5f)</span></li>
<li>shell/shellcorona.cpp <span style="color: \
grey">(84442ae60cf0f576a077e770ceae82a17721a456)</span></li>
<li>dataengines/share/shareservice.h <span style="color: \
grey">(5fb533d06fc74a52c33e0c8e1052ec93ffc4e11f)</span></li>
<li>dataengines/share/shareservice.cpp <span style="color: \
grey">(8442b6634e5e55f8717b9684dd41839df8d3d677)</span></li>
<li>krunner/main.cpp <span style="color: \
grey">(4d8cc31ff4d78c2daa0f9a6af247b3bd1c317ffa)</span></li>
<li>krunner/shellpluginloader.h <span style="color: \
grey">(9c0f62412eac4d1ad03c681325852d9efe25ccda)</span></li>
<li>krunner/view.cpp <span style="color: \
grey">(0d986e845e3b9821ef39a874d431a087e2390e8a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119989/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2044481964095932406==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic