'Re: Review Request 119557: use kpluginselector for enabling runners'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 119557: use kpluginselector for enabling runners
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2014-07-31 21:50:27
Message-ID: 20140731215027.15440.16007 () probe ! kde ! org
[Download RAW message or body]

--===============9185880346104109264==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119557/
-----------------------------------------------------------

(Updated July 31, 2014, 9:50 p.m.)

Review request for Plasma.

Changes
-------

clean up leftovers

Repository: plasma-desktop

Description
-------

there is a standard widget to enable or disable plugins used around: kpluginselector.
this is needed also to access the about dialog of runners (maybe not 100% needed) and \
the config dialog some runners have (that's absolutely needed) graphically looks \
similar, just a bit more detailed (displays comments from the metadata files as well)

note there is still a bug this uncovered before it can be merged (probably the reason \
it wasn't used before) the scrollbars are always hidden right now. that's a problem \
in kcategorizedview due to a workaround of an old Qt4 bug

Diffs (updated)
-----

  kcms/runners/kcm.h 0458430879964a10b2a15ff6660919874b7a5c3d 
  kcms/runners/kcm.cpp 0de07fbd73f692acb7b68efa665ba72dc8eddc5b 

Diff: https://git.reviewboard.kde.org/r/119557/diff/

Testing
-------

File Attachments
----------------

snapshot4.png
  https://git.reviewboard.kde.org/media/uploaded/files/2014/07/31/be11d3fa-5de4-496b-a79e-450bd78318e6__snapshot4.png

Thanks,

Marco Martin

--===============9185880346104109264==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119557/">https://git.reviewboard.kde.org/r/119557/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated July 31, 2014, 9:50 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">clean up leftovers</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">there is a standard widget to enable or disable \
plugins used around: kpluginselector.<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> this is needed also \
to access the about dialog of runners (maybe not 100% needed) and the config dialog \
some runners have (that's absolutely needed)<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> graphically looks \
similar, just a bit more detailed (displays comments from the metadata files as \
well)</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">note there is still a bug this uncovered before it can \
be merged (probably the reason it wasn't used before) the scrollbars are always \
hidden right now.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> that's a problem in kcategorizedview due to a \
workaround of an old Qt4 bug</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kcms/runners/kcm.h <span style="color: \
grey">(0458430879964a10b2a15ff6660919874b7a5c3d)</span></li>

 <li>kcms/runners/kcm.cpp <span style="color: \
grey">(0de07fbd73f692acb7b68efa665ba72dc8eddc5b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119557/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/07/31/be11d3fa-5de4-496b-a79e-450bd78318e6__snapshot4.png">snapshot4.png</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============9185880346104109264==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 