--===============2016034932193423213== Content-Type: multipart/alternative; boundary="===============9185880346104109264==" --===============9185880346104109264== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119557/ ----------------------------------------------------------- (Updated July 31, 2014, 9:50 p.m.) Review request for Plasma. Changes ------- clean up leftovers Repository: plasma-desktop Description ------- there is a standard widget to enable or disable plugins used around: kpluginselector. this is needed also to access the about dialog of runners (maybe not 100% needed) and the config dialog some runners have (that's absolutely needed) graphically looks similar, just a bit more detailed (displays comments from the metadata files as well) note there is still a bug this uncovered before it can be merged (probably the reason it wasn't used before) the scrollbars are always hidden right now. that's a problem in kcategorizedview due to a workaround of an old Qt4 bug Diffs (updated) ----- kcms/runners/kcm.h 0458430879964a10b2a15ff6660919874b7a5c3d kcms/runners/kcm.cpp 0de07fbd73f692acb7b68efa665ba72dc8eddc5b Diff: https://git.reviewboard.kde.org/r/119557/diff/ Testing ------- File Attachments ---------------- snapshot4.png https://git.reviewboard.kde.org/media/uploaded/files/2014/07/31/be11d3fa-5de4-496b-a79e-450bd78318e6__snapshot4.png Thanks, Marco Martin --===============9185880346104109264== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119557/

Review request for Plasma.

By Marco Martin.

Updated July 31, 2014, 9:50 p.m.

Changes

clean up leftovers

Repository: plasma-desktop

Description

there is a standard widget to enable or disable plugins used around: kpluginselector.
this is needed also to access the about dialog of runners (maybe not 100% needed) and the config dialog some runners have (that's absolutely needed)
graphically looks similar, just a bit more detailed (displays comments from the metadata files as well)

note there is still a bug this uncovered before it can be merged (probably the reason it wasn't used before) the scrollbars are always hidden right now.
that's a problem in kcategorizedview due to a workaround of an old Qt4 bug

Diffs (updated)

kcms/runners/kcm.h (0458430879964a10b2a15ff6660919874b7a5c3d)
kcms/runners/kcm.cpp (0de07fbd73f692acb7b68efa665ba72dc8eddc5b)

File Attachments

--===============9185880346104109264==-- --===============2016034932193423213== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2016034932193423213==--