'Re: Review Request 119554: Plasmoid initialization, screenForContainment'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 119554: Plasmoid initialization, screenForContainment
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2014-07-31 18:43:05
Message-ID: 20140731184305.3288.58404 () probe ! kde ! org
[Download RAW message or body]

--===============3919544452296101570==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119554/#review63593
-----------------------------------------------------------

Ship it!

bah, let's try to go for it

- Marco Martin

On July 31, 2014, 4:54 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119554/
> -----------------------------------------------------------
> 
> (Updated July 31, 2014, 4:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 335710
> https://bugs.kde.org/show_bug.cgi?id=335710
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> So far, when initializing plasma shell some plasmoids would trigger a warning in \
> ShellCorona::screenForContainment saying that the requested screen was not found. 
> This patch fixes the issue by introducing the screens to the views list earlier, \
> this way when screenForContainment is called, we already have the list initialized. \
> Now the problem is that we get some inconsistencies, because QApp::processEvents is \
> called from within View::setContainment. This results in requests to the \
> PlasmaShell on half-baked instances and resulted in problems. That's why I \
> introduced the loading attribute that wraps setContainment calls. 
> 
> Diffs
> -----
> 
> shell/shellcorona.cpp 09ef711 
> 
> Diff: https://git.reviewboard.kde.org/r/119554/diff/
> 
> 
> Testing
> -------
> 
> PlasmaShell seems to run fine on my system.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
> 

--===============3919544452296101570==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119554/">https://git.reviewboard.kde.org/r/119554/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">bah, \
let's try to go for it</p></pre>  <br />

<p>- Marco Martin</p>

<br />
<p>On July 31st, 2014, 4:54 p.m. UTC, Aleix Pol Gonzalez wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>

<p style="color: grey;"><i>Updated July 31, 2014, 4:54 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=335710">335710</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">So far, when initializing plasma shell some plasmoids \
would trigger a warning in ShellCorona::screenForContainment saying that the \
requested screen was not found.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch fixes the \
issue by introducing the screens to the views list earlier, this way when \
screenForContainment is called, we already have the list initialized. Now the problem \
is that we get some inconsistencies, because QApp::processEvents is called from \
within View::setContainment. This results in requests to the PlasmaShell on \
half-baked instances and resulted in problems. That's why I introduced the loading \
attribute that wraps setContainment calls.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">PlasmaShell seems to run fine on my system.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>shell/shellcorona.cpp <span style="color: grey">(09ef711)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119554/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3919544452296101570==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 