--===============1945815862977251828== Content-Type: multipart/alternative; boundary="===============3919544452296101570==" --===============3919544452296101570== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119554/#review63593 ----------------------------------------------------------- Ship it! bah, let's try to go for it - Marco Martin On July 31, 2014, 4:54 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119554/ > ----------------------------------------------------------- > > (Updated July 31, 2014, 4:54 p.m.) > > > Review request for Plasma. > > > Bugs: 335710 > https://bugs.kde.org/show_bug.cgi?id=335710 > > > Repository: plasma-workspace > > > Description > ------- > > So far, when initializing plasma shell some plasmoids would trigger a warning in ShellCorona::screenForContainment saying that the requested screen was not found. > > This patch fixes the issue by introducing the screens to the views list earlier, this way when screenForContainment is called, we already have the list initialized. Now the problem is that we get some inconsistencies, because QApp::processEvents is called from within View::setContainment. This results in requests to the PlasmaShell on half-baked instances and resulted in problems. That's why I introduced the loading attribute that wraps setContainment calls. > > > Diffs > ----- > > shell/shellcorona.cpp 09ef711 > > Diff: https://git.reviewboard.kde.org/r/119554/diff/ > > > Testing > ------- > > PlasmaShell seems to run fine on my system. > > > Thanks, > > Aleix Pol Gonzalez > > --===============3919544452296101570== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119554/

Ship it!

bah, let's try to go for it

- Marco Martin

On July 31st, 2014, 4:54 p.m. UTC, Aleix Pol Gonzalez wrote:

Review request for Plasma.

By Aleix Pol Gonzalez.

Updated July 31, 2014, 4:54 p.m.

Bugs: 335710

Repository: plasma-workspace

Description

So far, when initializing plasma shell some plasmoids would trigger a warning in ShellCorona::screenForContainment saying that the requested screen was not found.

This patch fixes the issue by introducing the screens to the views list earlier, this way when screenForContainment is called, we already have the list initialized. Now the problem is that we get some inconsistencies, because QApp::processEvents is called from within View::setContainment. This results in requests to the PlasmaShell on half-baked instances and resulted in problems. That's why I introduced the loading attribute that wraps setContainment calls.

Testing

PlasmaShell seems to run fine on my system.

Diffs

shell/shellcorona.cpp (09ef711)

--===============3919544452296101570==-- --===============1945815862977251828== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1945815862977251828==--