[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 119552: Kdeclarative: Introduce org.kde.kio component
From: "Marco Martin" <notmart () gmail ! com>
Date: 2014-07-31 16:54:08
Message-ID: 20140731165408.15440.27035 () probe ! kde ! org
[Download RAW message or body]
--===============4259332595676167058==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On July 31, 2014, 2:21 p.m., Aleix Pol Gonzalez wrote:
> > src/qmlcontrols/kioplugin/kio.cpp, line 33
> > <https://git.reviewboard.kde.org/r/119552/diff/1/?file=294573#file294573line33>
> >
> > What about creating a url handler for krun things?
> > http://qt-project.org/doc/qt-4.8/qdesktopservices.html#url-handlers
>
> Marco Martin wrote:
> that would also work.
> where it would be installed tough?
> still a kio import?
>
> Aleix Pol Gonzalez wrote:
> Well, we just need to call QDesktopServices::setUrlHandler, we could just put it in \
> libplasma or KGuiAddons (like help:/).
> That's how we do it for the help:/ url handler:
>
> Q_GLOBAL_STATIC(UrlHandler, s_handler)
>
> static void initializeGlobalSettings()
> {
> QDesktopServices::setUrlHandler(QStringLiteral("help"), s_handler, "openHelp");
> }
>
> Q_COREAPP_STARTUP_FUNCTION(initializeGlobalSettings)
depends if we want that krun:/ url be available from everywhere..
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119552/#review63571
-----------------------------------------------------------
On July 31, 2014, 10:54 a.m., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119552/
> -----------------------------------------------------------
>
> (Updated July 31, 2014, 10:54 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: kdeclarative
>
>
> Description
> -------
>
> With the specific component we will be able to open files,documents,applications \
> etc. Because until now we are not able to open them.
>
>
> Diffs
> -----
>
> src/qmlcontrols/CMakeLists.txt bab913b
> src/qmlcontrols/kioplugin/CMakeLists.txt PRE-CREATION
> src/qmlcontrols/kioplugin/kio.h PRE-CREATION
> src/qmlcontrols/kioplugin/kio.cpp PRE-CREATION
> src/qmlcontrols/kioplugin/kioplugin.h PRE-CREATION
> src/qmlcontrols/kioplugin/kioplugin.cpp PRE-CREATION
> src/qmlcontrols/kioplugin/qmldir PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/119552/diff/
>
>
> Testing
> -------
>
> Everything seems to work ok.
>
> * Applications open properly if we pass their desktop file as a parameter
> * Files and images are opening properly
>
>
>
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
--===============4259332595676167058==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119552/">https://git.reviewboard.kde.org/r/119552/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 31st, 2014, 2:21 p.m. UTC, <b>Aleix Pol \
Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119552/diff/1/?file=294573#file294573line33" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/qmlcontrols/kioplugin/kio.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">33</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">bool</span> <span class="n">Kio</span><span class="o">::</span><span \
class="n">openUrl</span><span class="p">(</span><span class="k">const</span> <span \
class="n">QString</span> <span class="o">&</span><span \
class="n">filePath</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What \
about creating a url handler for krun things?<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
http://qt-project.org/doc/qt-4.8/qdesktopservices.html#url-handlers</p></pre> \
</blockquote>
<p>On July 31st, 2014, 2:31 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">that \
would also work.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> where it would be installed tough?<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> still a kio import?</p></pre>
</blockquote>
<p>On July 31st, 2014, 4:33 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well, \
we just need to call QDesktopServices::setUrlHandler, we could just put it in \
libplasma or KGuiAddons (like help:/).</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">That's how we do it for \
the help:/ url handler:</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Q_GLOBAL_STATIC(UrlHandler, \
s_handler)</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">static void initializeGlobalSettings()<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> {<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> \
QDesktopServices::setUrlHandler(QStringLiteral("help"), s_handler, "openHelp");<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> }</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: \
inherit;">Q_COREAPP_STARTUP_FUNCTION(initializeGlobalSettings)</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">depends if we want that krun:/ url be available from everywhere..</p></pre> \
<br />
<p>- Marco</p>
<br />
<p>On July 31st, 2014, 10:54 a.m. UTC, Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated July 31, 2014, 10:54 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">With the specific component we will be able to open \
files,documents,applications etc.<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> Because until now we \
are not able to open them.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Everything seems to work ok.</p> <ul style="padding: \
0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: \
normal;"> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">Applications open properly if we pass their desktop \
file as a parameter</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Files and images are opening \
properly</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/qmlcontrols/CMakeLists.txt <span style="color: grey">(bab913b)</span></li>
<li>src/qmlcontrols/kioplugin/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kioplugin/kio.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kioplugin/kio.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kioplugin/kioplugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kioplugin/kioplugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/qmlcontrols/kioplugin/qmldir <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119552/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4259332595676167058==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic