--===============3055769154157543618== Content-Type: multipart/alternative; boundary="===============4259332595676167058==" --===============4259332595676167058== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On July 31, 2014, 2:21 p.m., Aleix Pol Gonzalez wrote: > > src/qmlcontrols/kioplugin/kio.cpp, line 33 > > > > > > What about creating a url handler for krun things? > > http://qt-project.org/doc/qt-4.8/qdesktopservices.html#url-handlers > > Marco Martin wrote: > that would also work. > where it would be installed tough? > still a kio import? > > Aleix Pol Gonzalez wrote: > Well, we just need to call QDesktopServices::setUrlHandler, we could just put it in libplasma or KGuiAddons (like help:/). > > That's how we do it for the help:/ url handler: > > Q_GLOBAL_STATIC(UrlHandler, s_handler) > > static void initializeGlobalSettings() > { > QDesktopServices::setUrlHandler(QStringLiteral("help"), s_handler, "openHelp"); > } > > Q_COREAPP_STARTUP_FUNCTION(initializeGlobalSettings) depends if we want that krun:/ url be available from everywhere.. - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119552/#review63571 ----------------------------------------------------------- On July 31, 2014, 10:54 a.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119552/ > ----------------------------------------------------------- > > (Updated July 31, 2014, 10:54 a.m.) > > > Review request for Plasma. > > > Repository: kdeclarative > > > Description > ------- > > With the specific component we will be able to open files,documents,applications etc. > Because until now we are not able to open them. > > > Diffs > ----- > > src/qmlcontrols/CMakeLists.txt bab913b > src/qmlcontrols/kioplugin/CMakeLists.txt PRE-CREATION > src/qmlcontrols/kioplugin/kio.h PRE-CREATION > src/qmlcontrols/kioplugin/kio.cpp PRE-CREATION > src/qmlcontrols/kioplugin/kioplugin.h PRE-CREATION > src/qmlcontrols/kioplugin/kioplugin.cpp PRE-CREATION > src/qmlcontrols/kioplugin/qmldir PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119552/diff/ > > > Testing > ------- > > Everything seems to work ok. > > * Applications open properly if we pass their desktop file as a parameter > * Files and images are opening properly > > > > > Thanks, > > Antonis Tsiapaliokas > > --===============4259332595676167058== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119552/

On July 31st, 2014, 2:21 p.m. UTC, Aleix Pol Gonzalez wrote:

src/qmlcontrols/kioplugin/kio.cpp (Diff revision 1)
33
bool Kio::openUrl(const QString &filePath)

What about creating a url handler for krun things?
http://qt-project.org/doc/qt-4.8/qdesktopservices.html#url-handlers

On July 31st, 2014, 2:31 p.m. UTC, Marco Martin wrote:

that would also work.
where it would be installed tough?
still a kio import?

On July 31st, 2014, 4:33 p.m. UTC, Aleix Pol Gonzalez wrote:

Well, we just need to call QDesktopServices::setUrlHandler, we could just put it in libplasma or KGuiAddons (like help:/).

That's how we do it for the help:/ url handler:

Q_GLOBAL_STATIC(UrlHandler, s_handler)

static void initializeGlobalSettings()
{
QDesktopServices::setUrlHandler(QStringLiteral("help"), s_handler, "openHelp");
}

Q_COREAPP_STARTUP_FUNCTION(initializeGlobalSettings)

depends if we want that krun:/ url be available from everywhere..


- Marco


On July 31st, 2014, 10:54 a.m. UTC, Antonis Tsiapaliokas wrote:

Review request for Plasma.
By Antonis Tsiapaliokas.

Updated July 31, 2014, 10:54 a.m.

Repository: kdeclarative

Description

With the specific component we will be able to open files,documents,applications etc.
Because until now we are not able to open them.

Testing

Everything seems to work ok.

  • Applications open properly if we pass their desktop file as a parameter
  • Files and images are opening properly

Diffs

  • src/qmlcontrols/CMakeLists.txt (bab913b)
  • src/qmlcontrols/kioplugin/CMakeLists.txt (PRE-CREATION)
  • src/qmlcontrols/kioplugin/kio.h (PRE-CREATION)
  • src/qmlcontrols/kioplugin/kio.cpp (PRE-CREATION)
  • src/qmlcontrols/kioplugin/kioplugin.h (PRE-CREATION)
  • src/qmlcontrols/kioplugin/kioplugin.cpp (PRE-CREATION)
  • src/qmlcontrols/kioplugin/qmldir (PRE-CREATION)

View Diff

--===============4259332595676167058==-- --===============3055769154157543618== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============3055769154157543618==--