'Re: Review Request 119535: Move QML bindings for KUser to kdeclarative'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 119535: Move QML bindings for KUser to kdeclarative
From:       Sebastian_Kügler <sebas () kde ! org>
Date:       2014-07-31 13:15:39
Message-ID: 20140731131539.15440.21619 () probe ! kde ! org
[Download RAW message or body]

--===============6375883394227212303==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119535/
-----------------------------------------------------------

(Updated July 31, 2014, 1:15 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks and Plasma.

Repository: kdeclarative

Description
-------

Move QML bindings for KUser to kdeclarative

This code has already been released, but privately inside Kickoff. As it is not strictly \
related (or limited to) Kickoff, I'd like to move it into kdeclarative. There are already other \
bindings for classes from KCoreAddons there, so this seems like a nice fit.

The class is useful as public API since it allows customization of apps, making the user feel \
more familiar with the program at hand. I want to use the name and face icon of the user in \
more places (systemsettings redesign comes to mind), so it'd be useful to have it shared.

Diffs
-----

  src/qmlcontrols/kcoreaddons/CMakeLists.txt 597cc2c 
  src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 3c1a96e 
  src/qmlcontrols/kcoreaddons/kuserproxy.h PRE-CREATION 
  src/qmlcontrols/kcoreaddons/kuserproxy.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119535/diff/

Testing
-------

Ported an (unreleased) app using this class to the new location, works as expected, no \
regressions encountered.

Thanks,

Sebastian Kügler

--===============6375883394227212303==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119535/">https://git.reviewboard.kde.org/r/119535/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Sebastian Kügler.</div>

<p style="color: grey;"><i>Updated July 31, 2014, 1:15 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Move QML \
bindings for KUser to kdeclarative</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This code has already been released, but \
privately inside Kickoff. As it is not strictly related (or limited to) Kickoff, I'd like to \
move it into kdeclarative. There are already other bindings for classes from KCoreAddons there, \
so this seems like a nice fit.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The class is useful as public API since it allows \
customization of apps, making the user feel more familiar with the program at hand. I want to \
use the name and face icon of the user in more places (systemsettings redesign comes to mind), \
so it'd be useful to have it shared.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ported an \
(unreleased) app using this class to the new location, works as expected, no regressions \
encountered.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/qmlcontrols/kcoreaddons/CMakeLists.txt <span style="color: grey">(597cc2c)</span></li>

 <li>src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp <span style="color: \
grey">(3c1a96e)</span></li>

 <li>src/qmlcontrols/kcoreaddons/kuserproxy.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/qmlcontrols/kcoreaddons/kuserproxy.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119535/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6375883394227212303==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 