--===============2663916154638853445== Content-Type: multipart/alternative; boundary="===============6375883394227212303==" --===============6375883394227212303== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/ ----------------------------------------------------------- (Updated July 31, 2014, 1:15 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description ------- Move QML bindings for KUser to kdeclarative This code has already been released, but privately inside Kickoff. As it is not strictly related (or limited to) Kickoff, I'd like to move it into kdeclarative. There are already other bindings for classes from KCoreAddons there, so this seems like a nice fit. The class is useful as public API since it allows customization of apps, making the user feel more familiar with the program at hand. I want to use the name and face icon of the user in more places (systemsettings redesign comes to mind), so it'd be useful to have it shared. Diffs ----- src/qmlcontrols/kcoreaddons/CMakeLists.txt 597cc2c src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 3c1a96e src/qmlcontrols/kcoreaddons/kuserproxy.h PRE-CREATION src/qmlcontrols/kcoreaddons/kuserproxy.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119535/diff/ Testing ------- Ported an (unreleased) app using this class to the new location, works as expected, no regressions encountered. Thanks, Sebastian Kügler --===============6375883394227212303== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/

This change has been marked as submitted.

Review request for KDE Frameworks and Plasma.
By Sebastian Kügler.

Updated July 31, 2014, 1:15 p.m.

Repository: kdeclarative

Description 

Move QML bindings for KUser to kdeclarative


This code has already been released, but privately inside Kickoff. As it is not strictly related (or limited to) Kickoff, I'd like to move it into kdeclarative. There are already other bindings for classes from KCoreAddons there, so this seems like a nice fit.


The class is useful as public API since it allows customization of apps, making the user feel more familiar with the program at hand. I want to use the name and face icon of the user in more places (systemsettings redesign comes to mind), so it'd be useful to have it shared.

Testing 

Ported an (unreleased) app using this class to the new location, works as expected, no regressions encountered.

Diffs

  • src/qmlcontrols/kcoreaddons/CMakeLists.txt (597cc2c)
  • src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp (3c1a96e)
  • src/qmlcontrols/kcoreaddons/kuserproxy.h (PRE-CREATION)
  • src/qmlcontrols/kcoreaddons/kuserproxy.cpp (PRE-CREATION)

View Diff
--===============6375883394227212303==-- --===============2663916154638853445== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2663916154638853445==--