[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 119523: port TextField to QtControls
From: "Marco Martin" <notmart () gmail ! com>
Date: 2014-07-31 9:50:13
Message-ID: 20140731095013.15443.50779 () probe ! kde ! org
[Download RAW message or body]
--===============6462541497625625161==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
On July 28, 2014, 6:54 p.m., Marco Martin wrote:
> > Which methods do we need the inner control for? I saw positionAtPos and \
> > positionToRectangle, any others?
>
> Marco Martin wrote:
> those two and passwordCharacter
>
> David Edmundson wrote:
> and missing properties are:
>
> passwordCharacter
> errorHighlight
>
> David Edmundson wrote:
> I had a look at passwordCharacter; in the pure QtQuick TextInput, the mask \
> character is set from the platform style hints (note, this is subtly different to \
> QStyle) and is something we can set in our frameworks integration \
> KdePlatformTheme::themeHint method.
> Obviously we need to keep API compatibility to have it in the control for now, but \
> it doesn't seem like something that would ever be a useful thing to use. Maybe it \
> can be deprecated whenever we do a PlasmaComponents 2.1
I don't actually care that much that the possibility stays there...
it's more for the api missing from the component. afaik is never used, but removing \
it is not nice anyways.. wonder if it just make sense making this property and the \
other functions just no op
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119523/#review63363
-----------------------------------------------------------
On July 28, 2014, 6:10 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119523/
> -----------------------------------------------------------
>
> (Updated July 28, 2014, 6:10 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> this ports TextField to Qt Controls.
>
> Not sure if is really meargeable tough, because the old one used to export several \
> properties and functions more, but they are not possible anymore, because in order \
> for them to work is needed the access to the internal TextInput, and we don't have \
> that, so some api should have to be dropped, breaking the compatibility promise. \
> (another option would be to still use an own implementation, but use a compatible \
> style anyways)
>
> Diffs
> -----
>
> src/declarativeimports/plasmacomponents/qml/TextField.qml 5bc6b58
> src/declarativeimports/plasmacomponents/qml/styles/TextFieldStyle.qml PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/119523/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
--===============6462541497625625161==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119523/">https://git.reviewboard.kde.org/r/119523/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 28th, 2014, 6:54 p.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Which methods do we need the inner control for? I saw \
positionAtPos and positionToRectangle, any others?</p></pre> </blockquote>
<p>On July 28th, 2014, 7:01 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">those \
two and passwordCharacter</p></pre> </blockquote>
<p>On July 28th, 2014, 7:02 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">and \
missing properties are:</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">passwordCharacter<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
errorHighlight</p></pre> </blockquote>
<p>On July 31st, 2014, 9:29 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I had \
a look at passwordCharacter; in the pure QtQuick TextInput, the mask character is set \
from the platform style hints (note, this is subtly different to QStyle) and is \
something we can set in our frameworks integration KdePlatformTheme::themeHint \
method.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Obviously we need to keep API compatibility to have it \
in the control for now, but it doesn't seem like something that would ever be a \
useful thing to use. Maybe it can be deprecated whenever we do a PlasmaComponents \
2.1</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't actually care that much that the possibility stays there...<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
it's more for the api missing from the component. afaik is never used, but removing \
it is not nice anyways..<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> wonder if it just make sense making \
this property and the other functions just no op</p></pre> <br />
<p>- Marco</p>
<br />
<p>On July 28th, 2014, 6:10 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated July 28, 2014, 6:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this ports TextField to Qt Controls.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Not sure if is really meargeable tough, because the old one used to export \
several properties and functions more, but they are not possible anymore, because in \
order for them to work is needed the access to the internal TextInput, and we don't \
have that, so some api should have to be dropped, breaking the compatibility \
promise.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> (another option would be to still use an own \
implementation, but use a compatible style anyways)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/plasmacomponents/qml/TextField.qml <span style="color: \
grey">(5bc6b58)</span></li>
<li>src/declarativeimports/plasmacomponents/qml/styles/TextFieldStyle.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119523/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6462541497625625161==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic