From kde-panel-devel Thu Jul 31 09:50:13 2014 From: "Marco Martin" Date: Thu, 31 Jul 2014 09:50:13 +0000 To: kde-panel-devel Subject: Re: Review Request 119523: port TextField to QtControls Message-Id: <20140731095013.15443.50779 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=140680023327281 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4020718313934522148==" --===============4020718313934522148== Content-Type: multipart/alternative; boundary="===============6462541497625625161==" --===============6462541497625625161== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit On July 28, 2014, 6:54 p.m., Marco Martin wrote: > > Which methods do we need the inner control for? I saw positionAtPos and positionToRectangle, any others? > > Marco Martin wrote: > those two and passwordCharacter > > David Edmundson wrote: > and missing properties are: > > passwordCharacter > errorHighlight > > David Edmundson wrote: > I had a look at passwordCharacter; in the pure QtQuick TextInput, the mask character is set from the platform style hints (note, this is subtly different to QStyle) and is something we can set in our frameworks integration KdePlatformTheme::themeHint method. > > Obviously we need to keep API compatibility to have it in the control for now, but it doesn't seem like something that would ever be a useful thing to use. Maybe it can be deprecated whenever we do a PlasmaComponents 2.1 I don't actually care that much that the possibility stays there... it's more for the api missing from the component. afaik is never used, but removing it is not nice anyways.. wonder if it just make sense making this property and the other functions just no op - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119523/#review63363 ----------------------------------------------------------- On July 28, 2014, 6:10 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119523/ > ----------------------------------------------------------- > > (Updated July 28, 2014, 6:10 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > this ports TextField to Qt Controls. > > Not sure if is really meargeable tough, because the old one used to export several properties and functions more, but they are not possible anymore, because in order for them to work is needed the access to the internal TextInput, and we don't have that, so some api should have to be dropped, breaking the compatibility promise. > (another option would be to still use an own implementation, but use a compatible style anyways) > > > Diffs > ----- > > src/declarativeimports/plasmacomponents/qml/TextField.qml 5bc6b58 > src/declarativeimports/plasmacomponents/qml/styles/TextFieldStyle.qml PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119523/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > > --===============6462541497625625161== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119523/

On July 28th, 2014, 6:54 p.m. UTC, David Edmundson wrote:

Which methods do we need the inner control for? I saw positionAtPos and positionToRectangle, any others?

On July 28th, 2014, 7:01 p.m. UTC, Marco Martin wrote:

those two and passwordCharacter

On July 28th, 2014, 7:02 p.m. UTC, David Edmundson wrote:

and missing properties are:

passwordCharacter
errorHighlight

On July 31st, 2014, 9:29 a.m. UTC, David Edmundson wrote:

I had a look at passwordCharacter; in the pure QtQuick TextInput, the mask character is set from the platform style hints (note, this is subtly different to QStyle) and is something we can set in our frameworks integration KdePlatformTheme::themeHint method.

Obviously we need to keep API compatibility to have it in the control for now, but it doesn't seem like something that would ever be a useful thing to use. Maybe it can be deprecated whenever we do a PlasmaComponents 2.1

I don't actually care that much that the possibility stays there...
it's more for the api missing from the component. afaik is never used, but removing it is not nice anyways..
wonder if it just make sense making this property and the other functions just no op

- Marco

On July 28th, 2014, 6:10 p.m. UTC, Marco Martin wrote:

Review request for KDE Frameworks and Plasma.

By Marco Martin.

Updated July 28, 2014, 6:10 p.m.

Repository: plasma-framework

Description

this ports TextField to Qt Controls.

Not sure if is really meargeable tough, because the old one used to export several properties and functions more, but they are not possible anymore, because in order for them to work is needed the access to the internal TextInput, and we don't have that, so some api should have to be dropped, breaking the compatibility promise.
(another option would be to still use an own implementation, but use a compatible style anyways)

Diffs

src/declarativeimports/plasmacomponents/qml/TextField.qml (5bc6b58)
src/declarativeimports/plasmacomponents/qml/styles/TextFieldStyle.qml (PRE-CREATION)

--===============6462541497625625161==-- --===============4020718313934522148== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============4020718313934522148==--