'Re: Review Request 119534: take defaults from a plasma look and feel package, if available'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 119534: take defaults from a plasma look and feel package, if available
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2014-07-29 16:22:32
Message-ID: 20140729162232.15443.73832 () probe ! kde ! org
[Download RAW message or body]

--===============1283666311498220337==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119534/
-----------------------------------------------------------

(Updated July 29, 2014, 4:22 p.m.)

Review request for KDE Frameworks and Plasma.

Changes
-------

if there is a colors file in the package, use it

Repository: frameworkintegration

Description
-------

there will be support for some kind of "mega theme" that besides providing files for \
splashscreen, lockscreen etc, will define what defaults to use among icons, colors, \
fonts etc.

This is a first start of it for reading the defaults. The theme file is stored in a \
plasma package, but the patch resolves the correct path by hand, not requiring \
linking to libplasma. right now only a couple of settings is used, mostly to see if \
the direction is good.

Diffs (updated)
-----

  src/platformtheme/khintssettings.h 57f1864 
  src/platformtheme/khintssettings.cpp 104f77c 

Diff: https://git.reviewboard.kde.org/r/119534/diff/

Testing
-------

Thanks,

Marco Martin

--===============1283666311498220337==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119534/">https://git.reviewboard.kde.org/r/119534/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated July 29, 2014, 4:22 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">if there is a colors file in the package, use it</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
frameworkintegration
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">there will be support for some kind of "mega theme" \
that besides providing files for splashscreen, lockscreen etc, will define what \
defaults to use among icons, colors, fonts etc.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
is a first start of it for reading the defaults. The theme file is stored in a plasma \
package, but the patch resolves the correct path by hand, not requiring linking to \
libplasma.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> right now only a couple of settings is used, mostly \
to see if the direction is good.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/platformtheme/khintssettings.h <span style="color: \
grey">(57f1864)</span></li>

 <li>src/platformtheme/khintssettings.cpp <span style="color: \
grey">(104f77c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119534/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1283666311498220337==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 