[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 119534: take defaults from a plasma look and feel package, if available
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2014-08-04 14:22:42
Message-ID: 20140804142242.20973.36946 () probe ! kde ! org
[Download RAW message or body]
--===============1739554031596328020==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119534/#review63781
-----------------------------------------------------------
src/platformtheme/khintssettings.cpp
<https://git.reviewboard.kde.org/r/119534/#comment44447>
you don't have to initialise SharedPtrs
src/platformtheme/khintssettings.cpp
<https://git.reviewboard.kde.org/r/119534/#comment44451>
I don't think we want to call the default look and feel package something like
maybe org.kde.defaultlookandfeel
otherwise you're just putting the type in the name which is just confusing.
src/platformtheme/khintssettings.cpp
<https://git.reviewboard.kde.org/r/119534/#comment44449>
so we don't want to be loading the cgIcons group then.
src/platformtheme/khintssettings.cpp
<https://git.reviewboard.kde.org/r/119534/#comment44450>
This means we'll end up with a KCM to change icons that does nothing. That sounds \
bad?
I was under the impression that we were using L&F to get the default icon set if \
one is not set.
- David Edmundson
On July 29, 2014, 4:22 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119534/
> -----------------------------------------------------------
>
> (Updated July 29, 2014, 4:22 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: frameworkintegration
>
>
> Description
> -------
>
> there will be support for some kind of "mega theme" that besides providing files \
> for splashscreen, lockscreen etc, will define what defaults to use among icons, \
> colors, fonts etc.
> This is a first start of it for reading the defaults. The theme file is stored in a \
> plasma package, but the patch resolves the correct path by hand, not requiring \
> linking to libplasma. right now only a couple of settings is used, mostly to see if \
> the direction is good.
>
> Diffs
> -----
>
> src/platformtheme/khintssettings.h 57f1864
> src/platformtheme/khintssettings.cpp 104f77c
>
> Diff: https://git.reviewboard.kde.org/r/119534/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
--===============1739554031596328020==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119534/">https://git.reviewboard.kde.org/r/119534/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119534/diff/3/?file=294399#file294399line45" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/platformtheme/khintssettings.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">45</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">KHintsSettings</span><span class="o">::</span><span \
class="n">KHintsSettings</span><span class="p">()</span> <span class="o">:</span> \
<span class="n">QObject</span><span class="p">(</span><span class="mi">0</span><span \
class="p">)</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">45</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="n">KHintsSettings</span><span \
class="o">::</span><span class="n">KHintsSettings</span><span class="p">()</span> \
<span class="o">:</span> <span class="n">QObject</span><span class="p">(</span><span \
class="mi">0</span><span class="p">)<span class="hl">,</span></span><span class="hl"> \
</span><span class="n"><span class="hl">mLnfConfig</span></span><span class="p"><span \
class="hl">(</span></span><span class="mi"><span class="hl">0</span></span><span \
class="p"><span class="hl">)</span></span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">you \
don't have to initialise SharedPtrs</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119534/diff/3/?file=294399#file294399line53" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/platformtheme/khintssettings.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">53</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">looknfeel</span> <span \
class="o">!=</span> <span class="s">"org.kde.lookandfeel"</span><span \
class="p">)</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't think we want to call the default look and feel package something like<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> maybe org.kde.defaultlookandfeel</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">otherwise you're just putting the type in the name \
which is just confusing.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119534/diff/3/?file=294399#file294399line258" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/platformtheme/khintssettings.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KHintsSettings::iconChanged(int group)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">206</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KConfigGroup</span> <span class="n">cgIcons</span><span \
class="p">(</span><span class="n">mKdeGlobals</span><span class="p">,</span> <span \
class="s">"Icons"</span><span class="p">);</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">258</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KConfigGroup</span> <span class="n">cgIcons</span><span \
class="p">(</span><span class="n">mKdeGlobals</span><span class="p">,</span> <span \
class="s">"Icons"</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">so we \
don't want to be loading the cgIcons group then.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119534/diff/3/?file=294399#file294399line259" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/platformtheme/khintssettings.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KHintsSettings::iconChanged(int group)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">207</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_hints</span><span class="p">[</span><span \
class="n">QPlatformTheme</span><span class="o">::</span><span \
class="n">SystemIconThemeName</span><span class="p">]</span> <span class="o">=</span> \
<span class="n"><span class="hl">cg</span>Icons</span><span class="p"><span \
class="hl">.</span></span><span class="n"><span \
class="hl">readEntry</span></span><span class="p"><span \
class="hl">(</span></span><span class="s">"Theme"</span><span \
class="p">,</span> <span class="s">"<span \
class="hl">oxygen</span>"</span><span class="p">);</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">259</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_hints</span><span class="p">[</span><span \
class="n">QPlatformTheme</span><span class="o">::</span><span \
class="n">SystemIconThemeName</span><span class="p">]</span> <span class="o">=</span> \
<span class="n"><span class="hl">readConfigValue</span></span><span class="p"><span \
class="hl">(</span></span><span class="s"><span class="hl">"</span>Icons<span \
class="hl">"</span></span><span class="p"><span class="hl">,</span></span><span \
class="hl"> </span><span class="s">"Theme"</span><span class="p">,</span> \
<span class="s">"<span class="hl">breeze</span>"</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
means we'll end up with a KCM to change icons that does nothing. That sounds bad?</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I was under the impression that we were using L&F \
to get the default icon set if one is not set.</p></pre> </div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On July 29th, 2014, 4:22 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated July 29, 2014, 4:22 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
frameworkintegration
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">there will be support for some kind of "mega theme" \
that besides providing files for splashscreen, lockscreen etc, will define what \
defaults to use among icons, colors, fonts etc.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
is a first start of it for reading the defaults. The theme file is stored in a plasma \
package, but the patch resolves the correct path by hand, not requiring linking to \
libplasma.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> right now only a couple of settings is used, mostly \
to see if the direction is good.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/platformtheme/khintssettings.h <span style="color: \
grey">(57f1864)</span></li>
<li>src/platformtheme/khintssettings.cpp <span style="color: \
grey">(104f77c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119534/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1739554031596328020==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic