'Re: Review Request 116898: Get rid of unnecessary Q_INVOKABLE declarations'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 116898: Get rid of unnecessary Q_INVOKABLE declarations
From:       "Shantanu Tushar" <shantanu () kde ! org>
Date:       2014-07-29 13:19:55
Message-ID: 20140729131955.15440.66653 () probe ! kde ! org
[Download RAW message or body]

--===============5364305347139097641==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116898/
-----------------------------------------------------------

(Updated July 29, 2014, 1:19 p.m.)

Status
------

This change has been discarded.

Review request for Plasma and Sujith Haridasan.

Repository: plasma-mediacenter

Description
-------

Methods supposed to be used as READ of Q_PROPERTY properties need not be invokable. \
Same goes for slots.

Diffs
-----

  libs/mpris2/mediaplayer2.h e68bc5c 
  libs/mpris2/mediaplayer2player.h 203d681 
  libs/mpris2/mpris2.h 0df64f4 
  libs/mpris2/mpris2.cpp a8ad3ef 
  shells/newshell/main.cpp bab6915 
  shells/newshell/mainwindow.cpp d2d71d4 

Diff: https://git.reviewboard.kde.org/r/116898/diff/

Testing
-------

Thanks,

Shantanu Tushar

--===============5364305347139097641==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116898/">https://git.reviewboard.kde.org/r/116898/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Sujith Haridasan.</div>
<div>By Shantanu Tushar.</div>

<p style="color: grey;"><i>Updated July 29, 2014, 1:19 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Methods supposed to be used as READ of Q_PROPERTY properties need not be \
invokable. Same goes for slots.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/mpris2/mediaplayer2.h <span style="color: grey">(e68bc5c)</span></li>

 <li>libs/mpris2/mediaplayer2player.h <span style="color: grey">(203d681)</span></li>

 <li>libs/mpris2/mpris2.h <span style="color: grey">(0df64f4)</span></li>

 <li>libs/mpris2/mpris2.cpp <span style="color: grey">(a8ad3ef)</span></li>

 <li>shells/newshell/main.cpp <span style="color: grey">(bab6915)</span></li>

 <li>shells/newshell/mainwindow.cpp <span style="color: grey">(d2d71d4)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116898/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5364305347139097641==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 