--===============9140127924487510436== Content-Type: multipart/alternative; boundary="===============5364305347139097641==" --===============5364305347139097641== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116898/ ----------------------------------------------------------- (Updated July 29, 2014, 1:19 p.m.) Status ------ This change has been discarded. Review request for Plasma and Sujith Haridasan. Repository: plasma-mediacenter Description ------- Methods supposed to be used as READ of Q_PROPERTY properties need not be invokable. Same goes for slots. Diffs ----- libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mpris2.h 0df64f4 libs/mpris2/mpris2.cpp a8ad3ef shells/newshell/main.cpp bab6915 shells/newshell/mainwindow.cpp d2d71d4 Diff: https://git.reviewboard.kde.org/r/116898/diff/ Testing ------- Thanks, Shantanu Tushar --===============5364305347139097641== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116898/

This change has been discarded.

Review request for Plasma and Sujith Haridasan.
By Shantanu Tushar.

Updated July 29, 2014, 1:19 p.m.

Repository: plasma-mediacenter

Description 

Methods supposed to be used as READ of Q_PROPERTY properties need not be invokable. Same goes for slots.

Diffs

  • libs/mpris2/mediaplayer2.h (e68bc5c)
  • libs/mpris2/mediaplayer2player.h (203d681)
  • libs/mpris2/mpris2.h (0df64f4)
  • libs/mpris2/mpris2.cpp (a8ad3ef)
  • shells/newshell/main.cpp (bab6915)
  • shells/newshell/mainwindow.cpp (d2d71d4)

View Diff
--===============5364305347139097641==-- --===============9140127924487510436== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============9140127924487510436==--