[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements
From: "Bhushan Shah" <bhush94 () gmail ! com>
Date: 2014-07-29 12:44:14
Message-ID: 20140729124414.15440.88620 () probe ! kde ! org
[Download RAW message or body]
--===============6465245008236591525==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114428/#review63431
-----------------------------------------------------------
Ping, whats status on this? can this be submitted?
- Bhushan Shah
On Dec. 13, 2013, 8:35 p.m., Heena Mahour wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114428/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2013, 8:35 p.m.)
>
>
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith \
> Haridasan.
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Replaced Text {} by PlasmaComponents.Label {}
>
>
> Diffs
> -----
>
> mediaelements/mediawelcome/BackendsListDelegate.qml e76af63
> mediaelements/mediawelcome/HomeScreenText.qml 35cd20a
>
> Diff: https://git.reviewboard.kde.org/r/114428/diff/
>
>
> Testing
> -------
>
> works fine .
>
>
> Thanks,
>
> Heena Mahour
>
>
--===============6465245008236591525==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114428/">https://git.reviewboard.kde.org/r/114428/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Ping, whats status on this? \
can this be submitted?</p></pre> <br />
<p>- Bhushan Shah</p>
<br />
<p>On December 13th, 2013, 8:35 p.m. IST, Heena Mahour wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith \
Haridasan.</div> <div>By Heena Mahour.</div>
<p style="color: grey;"><i>Updated Dec. 13, 2013, 8:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Replaced Text {} by PlasmaComponents.Label {} </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works fine .</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>mediaelements/mediawelcome/BackendsListDelegate.qml <span \
style="color: grey">(e76af63)</span></li>
<li>mediaelements/mediawelcome/HomeScreenText.qml <span style="color: \
grey">(35cd20a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114428/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6465245008236591525==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic