From kde-panel-devel Tue Jul 29 12:44:14 2014 From: "Bhushan Shah" Date: Tue, 29 Jul 2014 12:44:14 +0000 To: kde-panel-devel Subject: Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements Message-Id: <20140729124414.15440.88620 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=140663787206632 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4271108509168854378==" --===============4271108509168854378== Content-Type: multipart/alternative; boundary="===============6465245008236591525==" --===============6465245008236591525== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114428/#review63431 ----------------------------------------------------------- Ping, whats status on this? can this be submitted? - Bhushan Shah On Dec. 13, 2013, 8:35 p.m., Heena Mahour wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114428/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2013, 8:35 p.m.) > > > Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. > > > Repository: plasma-mediacenter > > > Description > ------- > > Replaced Text {} by PlasmaComponents.Label {} > > > Diffs > ----- > > mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 > mediaelements/mediawelcome/HomeScreenText.qml 35cd20a > > Diff: https://git.reviewboard.kde.org/r/114428/diff/ > > > Testing > ------- > > works fine . > > > Thanks, > > Heena Mahour > > --===============6465245008236591525== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114428/ 

Ping, whats status on this? can this be submitted?

- Bhushan Shah


On December 13th, 2013, 8:35 p.m. IST, Heena Mahour wrote:

Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
By Heena Mahour.

Updated Dec. 13, 2013, 8:35 p.m.

Repository: plasma-mediacenter

Description 

Replaced Text {} by PlasmaComponents.Label {}

Testing 

works fine .

Diffs

  • mediaelements/mediawelcome/BackendsListDelegate.qml (e76af63)
  • mediaelements/mediawelcome/HomeScreenText.qml (35cd20a)

View Diff
--===============6465245008236591525==-- --===============4271108509168854378== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============4271108509168854378==--