'Re: Review Request 118866: Start playing after Play All is used'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 118866: Start playing after Play All is used
From:       "Shantanu Tushar" <shantanu () kde ! org>
Date:       2014-07-29 12:35:48
Message-ID: 20140729123548.15443.14771 () probe ! kde ! org
[Download RAW message or body]

--===============2076256599917124371==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118866/
-----------------------------------------------------------

(Updated July 29, 2014, 12:35 p.m.)

Review request for Plasma.

Changes
-------

Consistent behavior for Local Browsing backends as well

Repository: plasma-mediacenter

Description
-------

We should ask the model to start playing once we add all the songs to the playlist as \
a result of the user using "Play All".

Diffs (updated)
-----

  libs/mediacenter/multipleplaylistmodel.h 1c7731b 
  libs/mediacenter/multipleplaylistmodel.cpp 950675e 
  libs/mediacenter/playlistmodel.h 50157ff 
  libs/mediacenter/playlistmodel.cpp 44abbc1 
  browsingbackends/localfiles/localfilesabstractbackend.cpp bbd511b 
  browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.cpp \
8b8e149 

Diff: https://git.reviewboard.kde.org/r/118866/diff/

Testing
-------

Thanks,

Shantanu Tushar

--===============2076256599917124371==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118866/">https://git.reviewboard.kde.org/r/118866/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Shantanu Tushar.</div>

<p style="color: grey;"><i>Updated July 29, 2014, 12:35 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Consistent behavior for Local Browsing backends as well</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">We should ask the model to start playing once we add \
all the songs to the playlist as a result of the user using "Play All".</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/mediacenter/multipleplaylistmodel.h <span style="color: \
grey">(1c7731b)</span></li>

 <li>libs/mediacenter/multipleplaylistmodel.cpp <span style="color: \
grey">(950675e)</span></li>

 <li>libs/mediacenter/playlistmodel.h <span style="color: grey">(50157ff)</span></li>

 <li>libs/mediacenter/playlistmodel.cpp <span style="color: \
grey">(44abbc1)</span></li>

 <li>browsingbackends/localfiles/localfilesabstractbackend.cpp <span style="color: \
grey">(bbd511b)</span></li>

 <li>browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.cpp \
<span style="color: grey">(8b8e149)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118866/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2076256599917124371==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 