From kde-panel-devel Tue Jul 29 12:35:48 2014 From: "Shantanu Tushar" Date: Tue, 29 Jul 2014 12:35:48 +0000 To: kde-panel-devel Subject: Re: Review Request 118866: Start playing after Play All is used Message-Id: <20140729123548.15443.14771 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=140663736606411 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0675689587517170680==" --===============0675689587517170680== Content-Type: multipart/alternative; boundary="===============2076256599917124371==" --===============2076256599917124371== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118866/ ----------------------------------------------------------- (Updated July 29, 2014, 12:35 p.m.) Review request for Plasma. Changes ------- Consistent behavior for Local Browsing backends as well Repository: plasma-mediacenter Description ------- We should ask the model to start playing once we add all the songs to the playlist as a result of the user using "Play All". Diffs (updated) ----- libs/mediacenter/multipleplaylistmodel.h 1c7731b libs/mediacenter/multipleplaylistmodel.cpp 950675e libs/mediacenter/playlistmodel.h 50157ff libs/mediacenter/playlistmodel.cpp 44abbc1 browsingbackends/localfiles/localfilesabstractbackend.cpp bbd511b browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.cpp 8b8e149 Diff: https://git.reviewboard.kde.org/r/118866/diff/ Testing ------- Thanks, Shantanu Tushar --===============2076256599917124371== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118866/

Review request for Plasma.
By Shantanu Tushar.

Updated July 29, 2014, 12:35 p.m.

Changes

Consistent behavior for Local Browsing backends as well
Repository: plasma-mediacenter

Description 

We should ask the model to start playing once we add all the songs to the playlist as a result of the user using "Play All".

Diffs (updated)

  • libs/mediacenter/multipleplaylistmodel.h (1c7731b)
  • libs/mediacenter/multipleplaylistmodel.cpp (950675e)
  • libs/mediacenter/playlistmodel.h (50157ff)
  • libs/mediacenter/playlistmodel.cpp (44abbc1)
  • browsingbackends/localfiles/localfilesabstractbackend.cpp (bbd511b)
  • browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.cpp (8b8e149)

View Diff
--===============2076256599917124371==-- --===============0675689587517170680== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0675689587517170680==--