'Re: Review Request 113697: Return focus to input widget after pressing alt key in the screen locker.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 113697: Return focus to input widget after pressing alt key in the screen locker.
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2014-07-29 10:30:09
Message-ID: 20140729103009.15443.30075 () probe ! kde ! org
[Download RAW message or body]

--===============1973573146707574346==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113697/#review63412
-----------------------------------------------------------

Ship it!

may be pushed to 4.x

- Marco Martin

On Nov. 27, 2013, 12:27 a.m., Teemu Rytilahti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113697/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2013, 12:27 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 314720, 316084, 319935, and 324821
> http://bugs.kde.org/show_bug.cgi?id=314720
> http://bugs.kde.org/show_bug.cgi?id=316084
> http://bugs.kde.org/show_bug.cgi?id=319935
> http://bugs.kde.org/show_bug.cgi?id=324821
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> The focus is being stolen from the input field when alt is being pressed in order \
> to make it possible to use keyboard to do unlocking. Unfortunately this causes the \
> focus never to be returned to the input field. 
> This fixes at least 314720, but perhaps other similar bugs such as 324821 too. \
> 324821 is also partially related. 
> 
> Diffs
> -----
> 
> ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml \
> 66a3bb4  
> Diff: https://git.reviewboard.kde.org/r/113697/diff/
> 
> 
> Testing
> -------
> 
> Tested on recent git installation.
> 
> 
> Thanks,
> 
> Teemu Rytilahti
> 
> 

--===============1973573146707574346==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/113697/">https://git.reviewboard.kde.org/r/113697/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">may \
be pushed to 4.x</p></pre>  <br />

<p>- Marco Martin</p>

<br />
<p>On novembre 27th, 2013, 12:27 a.m. UTC, Teemu Rytilahti wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Teemu Rytilahti.</div>

<p style="color: grey;"><i>Updated Nov. 27, 2013, 12:27 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=314720">314720</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=316084">316084</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=319935">319935</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=324821">324821</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The focus is being stolen from the input field when alt is being pressed \
in order to make it possible to use keyboard to do unlocking. Unfortunately this \
causes the focus never to be returned to the input field.

This fixes at least 314720, but perhaps other similar bugs such as 324821 too. 324821 \
is also partially related.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on recent git installation.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/screenlocker/greeter/themes/org.kde.passworddialog/contents/ui/Greeter.qml \
<span style="color: grey">(66a3bb4)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/113697/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1973573146707574346==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 