'Re: Review Request 109780: Enable following links/urls from the plasma notifications popup applet'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 109780: Enable following links/urls from the plasma notifications popup applet
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2014-07-29 10:29:24
Message-ID: 20140729102924.15443.92265 () probe ! kde ! org
[Download RAW message or body]

--===============2278731233178476538==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109780/#review63411
-----------------------------------------------------------

Ship it!

pushing this to 4.x would be fine

- Marco Martin

On Mar. 28, 2013, 8:20 p.m., Amín Guzmán Vargas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/109780/
> -----------------------------------------------------------
> 
> (Updated Mar. 28, 2013, 8:20 p.m.)
> 
> 
> Review request for Plasma, Davide Bettio and Marco Martin.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> The ability to follow a link embedded in a popup notification was disabled with the \
> migration to QML of the plasma notification plasmoid. This is a simple patch that \
> re-enables this functionality. 
> 
> Diffs
> -----
> 
> plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 2fa1b11 
> plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml \
> ed8ed99  
> Diff: https://git.reviewboard.kde.org/r/109780/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Amín Guzmán Vargas
> 
> 

--===============2278731233178476538==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/109780/">https://git.reviewboard.kde.org/r/109780/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">pushing this to 4.x would be fine</p></pre>  <br />

<p>- Marco Martin</p>

<br />
<p>On marzo 28th, 2013, 8:20 p.m. UTC, Amín Guzmán Vargas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, Davide Bettio and Marco Martin.</div>
<div>By Amín Guzmán Vargas.</div>

<p style="color: grey;"><i>Updated Mar. 28, 2013, 8:20 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The ability to follow a link embedded in a popup notification was \
disabled with the migration to QML of the plasma notification plasmoid. This is a \
simple patch that re-enables this functionality.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml <span \
style="color: grey">(2fa1b11)</span></li>

 <li>plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml \
<span style="color: grey">(ed8ed99)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/109780/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2278731233178476538==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 