[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118978: [screenlocker/greeter] Disable session management in the greeter
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2014-06-28 6:00:31
Message-ID: 20140628060031.18724.4837 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 27, 2014, 11:16 p.m., David Edmundson wrote:
> > ksmserver/screenlocker/greeter/main.cpp, line 65
> > <https://git.reviewboard.kde.org/r/118978/diff/1/?file=284963#file284963line65>
> >
> > why do we need it here too?
Honestly: I do not know. But I once went through KApplication code on how to disable \
session management and it did that in both methods so I used that when I adjusted \
klipper and took the code from klipper here.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118978/#review61110
-----------------------------------------------------------
On June 27, 2014, 5:26 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118978/
> -----------------------------------------------------------
>
> (Updated June 27, 2014, 5:26 p.m.)
>
>
> Review request for Plasma and Harald Sitter.
>
>
> Bugs: 336793
> https://bugs.kde.org/show_bug.cgi?id=336793
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> [screenlocker/greeter] Disable session management in the greeter
>
> We don't want to have the greeter being restored on session startup if
> one shut down the system from the lock screen.
>
> BUG: 336793
>
>
> Diffs
> -----
>
> ksmserver/screenlocker/greeter/main.cpp c708a2f9be0ac8a214045d775cc3489d3dfdb5ab
>
> Diff: https://git.reviewboard.kde.org/r/118978/diff/
>
>
> Testing
> -------
>
> shut down system from lock screen before and after change.
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118978/">https://git.reviewboard.kde.org/r/118978/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 27th, 2014, 11:16 p.m. CEST, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118978/diff/1/?file=284963#file284963line65" \
style="color: black; font-weight: bold; text-decoration: \
underline;">ksmserver/screenlocker/greeter/main.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int \
main(int argc, char* argv[])</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">65</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QObject</span><span class="o">::</span><span class="n">connect</span><span \
class="p">(</span><span class="o">&</span><span class="n">app</span><span \
class="p">,</span> <span class="o">&</span><span \
class="n">QGuiApplication</span><span class="o">::</span><span \
class="n">commitDataRequest</span><span class="p">,</span> <span \
class="n">disableSessionManagement</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why do we need it here \
too?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Honestly: I \
do not know. But I once went through KApplication code on how to disable session \
management and it did that in both methods so I used that when I adjusted klipper and \
took the code from klipper here.</pre> <br />
<p>- Martin</p>
<br />
<p>On June 27th, 2014, 5:26 p.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Harald Sitter.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated June 27, 2014, 5:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=336793">336793</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">[screenlocker/greeter] Disable session management in the greeter
We don't want to have the greeter being restored on session startup if
one shut down the system from the lock screen.
BUG: 336793</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">shut down system from lock screen before and after change.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/greeter/main.cpp <span style="color: \
grey">(c708a2f9be0ac8a214045d775cc3489d3dfdb5ab)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118978/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic