--===============5230766848156544405== Content-Type: multipart/alternative; boundary="===============4774789288296710400==" --===============4774789288296710400== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > On June 27, 2014, 11:16 p.m., David Edmundson wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 65 > > > > > > why do we need it here too? Honestly: I do not know. But I once went through KApplication code on how to disable session management and it did that in both methods so I used that when I adjusted klipper and took the code from klipper here. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118978/#review61110 ----------------------------------------------------------- On June 27, 2014, 5:26 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118978/ > ----------------------------------------------------------- > > (Updated June 27, 2014, 5:26 p.m.) > > > Review request for Plasma and Harald Sitter. > > > Bugs: 336793 > https://bugs.kde.org/show_bug.cgi?id=336793 > > > Repository: plasma-workspace > > > Description > ------- > > [screenlocker/greeter] Disable session management in the greeter > > We don't want to have the greeter being restored on session startup if > one shut down the system from the lock screen. > > BUG: 336793 > > > Diffs > ----- > > ksmserver/screenlocker/greeter/main.cpp c708a2f9be0ac8a214045d775cc3489d3dfdb5ab > > Diff: https://git.reviewboard.kde.org/r/118978/diff/ > > > Testing > ------- > > shut down system from lock screen before and after change. > > > Thanks, > > Martin Gräßlin > > --===============4774789288296710400== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118978/

On June 27th, 2014, 11:16 p.m. CEST, David Edmundson wrote:
ksmserver/screenlocker/greeter/main.cpp (Diff revision 1)
int main(int argc, char* argv[])
65
    QObject::connect(&app, &QGuiApplication::commitDataRequest, disableSessionManagement);
why do we need it here too?

Honestly: I do not know. But I once went through KApplication code on how to disable session management and it did that in both methods so I used that when I adjusted klipper and took the code from klipper here.

- Martin

On June 27th, 2014, 5:26 p.m. CEST, Martin Gräßlin wrote:

Review request for Plasma and Harald Sitter.

By Martin Gräßlin.

Updated June 27, 2014, 5:26 p.m.

Bugs: 336793

Repository: plasma-workspace

Description

[screenlocker/greeter] Disable session management in the greeter

We don't want to have the greeter being restored on session startup if
one shut down the system from the lock screen.

BUG: 336793

Testing

shut down system from lock screen before and after change.

Diffs

ksmserver/screenlocker/greeter/main.cpp (c708a2f9be0ac8a214045d775cc3489d3dfdb5ab)

--===============4774789288296710400==-- --===============5230766848156544405== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============5230766848156544405==--