[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118767: Fix for "Bug 328532 - Remember the playlist I was using when I closed PMC
From: Shantanu Tushar Jha <shantanu () kde ! org>
Date: 2014-06-19 17:29:32
Message-ID: CABQ4Km_+qOpn75GuOE1UGeVVOSi0YAcsGuSQ5-Oi9xDCkB-Zcw () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi Harish,
This is a known issue and is due to the fact that we don't save state while
switching the playlists. Maybe someone should report a bug if not already.
On Thu, Jun 19, 2014 at 10:44 PM, R.Harish Navnit <harishnavnit@gmail.com>
wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118767/
>
> On June 19th, 2014, 4:48 p.m. UTC, *Shantanu Tushar* wrote:
>
> libs/mediacenter/playlistmodel.cpp
> <https://git.reviewboard.kde.org/r/118767/diff/2/?file=282626#file282626line56> \
> (Diff revision 2)
>
> public:
>
> 56
>
> d->playlistName = s.value("lastPlaylist", \
> QVariant(DEFAULT_PLAYLIST_NAME)).toString();
> The explicit call to QVariant should not be needed
>
> I have just one issue in this. This is how I tested it.
>
> 1. Play a media from a playlist
> 2. Switch to another playlist
> 3. Return back to the playlist playing the current song.
> 4. Next and prev don't work.
> 5. Once the track finshes playing, the next track is not played. The mediacenter \
> stops playing any media and I have to mannually choose a new media again.
> Imagine doing this over and over again once playlists are switched.
>
> Does anyone else face the same issue ?
>
>
> - R.Harish
>
> On June 19th, 2014, 4:30 p.m. UTC, Ashish Madeti wrote:
> Review request for Plasma, Bhushan Shah, Nikolaos Chatzidakis, Shantanu
> Tushar, Sinny Kumari, and Sujith Haridasan.
> By Ashish Madeti.
>
> *Updated June 19, 2014, 4:30 p.m.*
> *Bugs: * 328532 <http://bugs.kde.org/show_bug.cgi?id=328532>
> *Repository: * plasma-mediacenter
> Description
>
> PMC didn't used to remember the playlist I was on the last time, when restarting \
> it. Now it saves the "lastPlaylist" while closing in the settings, and when \
> starting it loads the value of "lastPlaylist" in settings
> Diffs
>
> - libs/mediacenter/playlistmodel.cpp (dccaf52)
>
> View Diff <https://git.reviewboard.kde.org/r/118767/diff/>
>
--
Shantanu Tushar (UTC +0530)
http://www.shantanutushar.com
[Attachment #5 (text/html)]
<div dir="ltr"><div>Hi Harish,<br><br></div>This is a known issue and is due to the \
fact that we don't save state while switching the playlists. Maybe someone should \
report a bug if not already.<br></div><div class="gmail_extra"> <br><br><div \
class="gmail_quote">On Thu, Jun 19, 2014 at 10:44 PM, R.Harish Navnit <span \
dir="ltr"><<a href="mailto:harishnavnit@gmail.com" \
target="_blank">harishnavnit@gmail.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><div class="">
<table style="border:1px #c9c399 solid" bgcolor="#f9f3c9" cellpadding="8" \
width="100%"> <tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118767/" \
target="_blank">https://git.reviewboard.kde.org/r/118767/</a> </td>
</tr>
</tbody></table>
<br>
</div><div class=""><blockquote style="margin-left:1em;border-left:2px solid \
#d0d0d0;padding-left:10px"> <p style="margin-top:0">On June 19th, 2014, 4:48 p.m. \
UTC, <b>Shantanu Tushar</b> wrote:</p> <blockquote \
style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<table bgcolor="white" border="0" width="100%">
<thead>
<tr>
<th colspan="4" style="border-bottom:1px solid #c0c0c0;font-size:9pt;padding:4px \
8px;text-align:left" bgcolor="#F0F0F0"> <a \
href="https://git.reviewboard.kde.org/r/118767/diff/2/?file=282626#file282626line56" \
style="color:black;font-weight:bold;text-decoration:underline" \
target="_blank">libs/mediacenter/playlistmodel.cpp</a> <span \
style="font-weight:normal">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color:#e4d9cb;padding:4px 8px;text-align:center">
<tr>
<td colspan="4"><pre \
style="font-size:8pt;line-height:140%;margin:0">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th style="border-right:1px solid #c0c0c0" align="right" \
bgcolor="#b1ebb0"><font></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size:8pt;line-height:140%;margin:0"></pre></td> <th \
style="border-left:1px solid #c0c0c0;border-right:1px solid #c0c0c0" align="right" \
bgcolor="#b1ebb0"><font>56</font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size:8pt;line-height:140%;margin:0"> \
<span>d</span><span>-></span><span>playlistName</span> <span>=</span> \
<span>s</span><span>.</span><span>value</span><span>(</span><span>"lastPlaylist"</span><span>,</span> \
<span>QVariant</span><span>(</span><span>DEFAULT_PLAYLIST_NAME</span><span>)).</span><span>toString</span><span>();</span></pre>
</td>
</tr>
</tbody>
</table>
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">The \
explicit call to QVariant should not be needed</pre> </blockquote>
</blockquote>
</div><pre style="margin-left:1em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">I \
have just one issue in this. This is how I tested it.
1. Play a media from a playlist
2. Switch to another playlist
3. Return back to the playlist playing the current song.
4. Next and prev don't work.
5. Once the track finshes playing, the next track is not played. The mediacenter \
stops playing any media and I have to mannually choose a new media again.
Imagine doing this over and over again once playlists are switched.
Does anyone else face the same issue ? </pre><span class="HOEnZb"><font \
color="#888888"> <br>
<p>- R.Harish </p></font></span><div class="">
<br>
<p>On June 19th, 2014, 4:30 p.m. UTC, Ashish Madeti wrote:</p>
<table style="background-image:url('');background-repeat:repeat-x;border:1px \
black solid" bgcolor="#fefadf" cellpadding="8" cellspacing="0" width="100%"> \
<tbody><tr> <td>
<div>Review request for Plasma, Bhushan Shah, Nikolaos Chatzidakis, Shantanu Tushar, \
Sinny Kumari, and Sujith Haridasan.</div> <div>By Ashish Madeti.</div>
<p style="color:grey"><i>Updated June 19, 2014, 4:30 p.m.</i></p>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt;margin-top:1.5em">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=328532" target="_blank">328532</a>
</div>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt">Repository: </b>
plasma-mediacenter
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" \
cellspacing="0" width="100%"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">PMC \
didn't used to remember the playlist I was on the last time, when restarting it. \
Now it saves the "lastPlaylist" while closing in the settings, and when \
starting it loads the value of "lastPlaylist" in settings</pre> </td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>libs/mediacenter/playlistmodel.cpp <span \
style="color:grey">(dccaf52)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118767/diff/" style="margin-left:3em" \
target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div></div>
</div>
</blockquote></div><br><br clear="all"><br>-- <br>Shantanu Tushar (UTC \
+0530)<br><a href="http://www.shantanutushar.com" \
target="_blank">http://www.shantanutushar.com</a> </div>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic