From kde-panel-devel Thu Jun 19 17:29:32 2014 From: Shantanu Tushar Jha Date: Thu, 19 Jun 2014 17:29:32 +0000 To: kde-panel-devel Subject: Re: Review Request 118767: Fix for "Bug 328532 - Remember the playlist I was using when I closed PMC Message-Id: X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=140319826509212 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2401497854071303215==" --===============2401497854071303215== Content-Type: multipart/alternative; boundary=001a11c3ad58682fa304fc338dca --001a11c3ad58682fa304fc338dca Content-Type: text/plain; charset=UTF-8 Hi Harish, This is a known issue and is due to the fact that we don't save state while switching the playlists. Maybe someone should report a bug if not already. On Thu, Jun 19, 2014 at 10:44 PM, R.Harish Navnit wrote: > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118767/ > > On June 19th, 2014, 4:48 p.m. UTC, *Shantanu Tushar* wrote: > > libs/mediacenter/playlistmodel.cpp > (Diff > revision 2) > > public: > > 56 > > d->playlistName = s.value("lastPlaylist", QVariant(DEFAULT_PLAYLIST_NAME)).toString(); > > The explicit call to QVariant should not be needed > > I have just one issue in this. This is how I tested it. > > 1. Play a media from a playlist > 2. Switch to another playlist > 3. Return back to the playlist playing the current song. > 4. Next and prev don't work. > 5. Once the track finshes playing, the next track is not played. The mediacenter stops playing any media and I have to mannually choose a new media again. > > Imagine doing this over and over again once playlists are switched. > > Does anyone else face the same issue ? > > > - R.Harish > > On June 19th, 2014, 4:30 p.m. UTC, Ashish Madeti wrote: > Review request for Plasma, Bhushan Shah, Nikolaos Chatzidakis, Shantanu > Tushar, Sinny Kumari, and Sujith Haridasan. > By Ashish Madeti. > > *Updated June 19, 2014, 4:30 p.m.* > *Bugs: * 328532 > *Repository: * plasma-mediacenter > Description > > PMC didn't used to remember the playlist I was on the last time, when restarting it. > Now it saves the "lastPlaylist" while closing in the settings, and when starting it loads the value of "lastPlaylist" in settings > > Diffs > > - libs/mediacenter/playlistmodel.cpp (dccaf52) > > View Diff > -- Shantanu Tushar (UTC +0530) http://www.shantanutushar.com --001a11c3ad58682fa304fc338dca Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Harish,

This is a known issue and is = due to the fact that we don't save state while switching the playlists.= Maybe someone should report a bug if not already.


On Thu, Jun 19, 2014 at 10:44 PM, R.Hari= sh Navnit <harishnavnit@gmail.com> wrote:
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118767/

On June 19th, 2014, 4:48 p.m. UTC, Shantanu T= ushar wrote:

=20 
public:
=20 =20
libs/mediacenter/playlistmodel.cpp (Diff revision 2) 

    56
    
    d->playlistNam=
e =3D s.value("lastPlaylist", QVaria=
nt(DEFAULT_PLAYLIST_NAME)).toString();


  


 




  
The explicit call t=
o QVariant should not be needed

 









I have just one issue in this. This is how I tested it.=20

1. Play a media from a playlist
2. Switch to another playlist
3. Return back to the playlist playing the current song.=20
4. Next and prev don't work.=20
5. Once the track finshes playing, the next track is not played. The mediac=
enter stops playing any media and I have to mannually choose a new media ag=
ain.=20

Imagine doing this over and over again once playlists are switched.=20

Does anyone else face the same issue ? 








- R.Harish 






On June 19th, 2014, 4:30 p.m. UTC, Ashish Madeti wrote:











 

  


Review request for Plasma, Bhushan Shah, Nikolaos Chatzidakis, Shantan=
u Tushar, Sinny Kumari, and Sujith Haridasan.


By Ashish Madeti.




Updated June 19, 2014, 4:30 p.m.










 Bugs: 


 328532









 Repository: 
plasma-mediacenter





Description 
 

 

  
   
PMC didn't used to remember the playlist I was on the last time, when =
restarting it.
Now it saves the "lastPlaylist" while closing in the settings, an=
d when starting it loads the value of "lastPlaylist" in settings<=
/pre>
  

 







Diffs 


    

 
  • libs/mediacenter/playlistmodel.cpp (dccaf52=
)
    • 





View Diff








  		
 











  

 







-- 
Shantanu Tushar=C2=A0 =
=C2=A0 (UTC +0530)
http://www.shantanutushar.com



--001a11c3ad58682fa304fc338dca--

--===============2401497854071303215==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

--===============2401497854071303215==--