[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 118423: [klipper] Port KMimeType to QMimeType
From: "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date: 2014-05-30 13:49:39
Message-ID: 20140530134939.2659.63677 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 30, 2014, 1:15 p.m., David Edmundson wrote:
> > klipper/urlgrabber.cpp, line 140
> > <https://git.reviewboard.kde.org/r/118423/diff/1/?file=276477#file276477line140>
> >
> > we lose fast mode here.
> > I think this means if I drag a 100Gb file from the internet onto klipper it will \
> > start downloading it.
> > Not sure how problematic this is.
>
> Martin Gräßlin wrote:
> given the documentation that should be fine, see \
> http://qt-project.org/doc/qt-5/qmimedatabase.html#mimeTypeForUrl
> my interpretation of the documentation is that it won't download
Yes, it won't download, it will just return a default mimetype, which is actually \
pretty bad...
> On May 30, 2014, 1:15 p.m., David Edmundson wrote:
> > klipper/urlgrabber.cpp, line 147
> > <https://git.reviewboard.kde.org/r/118423/diff/1/?file=276477#file276477line147>
> >
> > this comment doesn't seem true, we explicitly check if the mimetype is html
>
> Martin Gräßlin wrote:
> I read this comment different: if clipboard contents starts with http, enforce the \
> mimetype to be html, because that's what's being done in the if
Yep, it's just ensuring it's html if it's http.
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118423/#review58802
-----------------------------------------------------------
On May 30, 2014, 1:38 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118423/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 1:38 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> [klipper] Port KMimeType to QMimeType
>
>
> Diffs
> -----
>
> klipper/urlgrabber.cpp 4eccb7065ae2932cc548c902ab3a8c50e4972444
>
> Diff: https://git.reviewboard.kde.org/r/118423/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118423/">https://git.reviewboard.kde.org/r/118423/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 30th, 2014, 1:15 p.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118423/diff/1/?file=276477#file276477line140" \
style="color: black; font-weight: bold; text-decoration: \
underline;">klipper/urlgrabber.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
URLGrabber::matchingMimeActions(const QString& clipData)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">139</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="nb">false</span><span class="p">,</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">139</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QMimeType</span> <span class="n">mimetype</span> <span class="o">=</span> \
<span class="n">db</span><span class="p">.</span><span \
class="n">mimeTypeForUrl</span><span class="p">(</span><span \
class="n">url</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">we lose fast mode here. \
I think this means if I drag a 100Gb file from the internet onto klipper it will \
start downloading it.
Not sure how problematic this is.</pre>
</blockquote>
<p>On May 30th, 2014, 1:23 p.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">given the documentation \
that should be fine, see \
http://qt-project.org/doc/qt-5/qmimedatabase.html#mimeTypeForUrl
my interpretation of the documentation is that it won't download</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, it \
won't download, it will just return a default mimetype, which is actually pretty \
bad...</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 30th, 2014, 1:15 p.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/118423/diff/1/?file=276477#file276477line147" \
style="color: black; font-weight: bold; text-decoration: \
underline;">klipper/urlgrabber.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
URLGrabber::matchingMimeActions(const QString& clipData)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">146</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// first: \
if clipboard contents starts with http, let's assume it's \
"text/html".</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: \
1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">145</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="c1">// first: if clipboard \
contents starts with http, let's assume it's \
"text/html".</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this comment doesn't \
seem true, we explicitly check if the mimetype is html</pre> </blockquote>
<p>On May 30th, 2014, 1:35 p.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I read this comment \
different: if clipboard contents starts with http, enforce the mimetype to be html, \
because that's what's being done in the if</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yep, \
it's just ensuring it's html if it's http.</pre> <br />
<p>- Aleix</p>
<br />
<p>On May 30th, 2014, 1:38 p.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated May 30, 2014, 1:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">[klipper] Port KMimeType to QMimeType</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>klipper/urlgrabber.cpp <span style="color: \
grey">(4eccb7065ae2932cc548c902ab3a8c50e4972444)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118423/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic