This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118423/

On May 30th, 2014, 1:15 p.m. UTC, David Edmundson wrote:

klipper/urlgrabber.cpp (Diff revision 1)
void URLGrabber::matchingMimeActions(const QString& clipData)
139	false,	139	QMimeType mimetype = db.mimeTypeForUrl(url);

we lose fast mode here.
I think this means if I drag a 100Gb file from the internet onto klipper it will start downloading it.

Not sure how problematic this is.

On May 30th, 2014, 1:23 p.m. UTC, Martin Gräßlin wrote:

given the documentation that should be fine, see http://qt-project.org/doc/qt-5/qmimedatabase.html#mimeTypeForUrl

my interpretation of the documentation is that it won't download

Yes, it won't download, it will just return a default mimetype, which is actually pretty bad...

On May 30th, 2014, 1:15 p.m. UTC, David Edmundson wrote:

klipper/urlgrabber.cpp (Diff revision 1)
void URLGrabber::matchingMimeActions(const QString& clipData)
146	// first: if clipboard contents starts with http, let's assume it's "text/html".	145	// first: if clipboard contents starts with http, let's assume it's "text/html".

klipper/urlgrabber.cpp (Diff revision 1)

void URLGrabber::matchingMimeActions(const QString& clipData)

146

    // first: if clipboard contents starts with http, let's assume it's "text/html".

145

    // first: if clipboard contents starts with http, let's assume it's "text/html".

this comment doesn't seem true, we explicitly check if the mimetype is html

On May 30th, 2014, 1:35 p.m. UTC, Martin Gräßlin wrote:

I read this comment different: if clipboard contents starts with http, enforce the mimetype to be html, because that's what's being done in the if

Yep, it's just ensuring it's html if it's http.

- Aleix

On May 30th, 2014, 1:38 p.m. UTC, Martin Gräßlin wrote:

Review request for Plasma.

By Martin Gräßlin.

Updated May 30, 2014, 1:38 p.m.

Repository: plasma-workspace

Description

[klipper] Port KMimeType to QMimeType

Diffs

klipper/urlgrabber.cpp (4eccb7065ae2932cc548c902ab3a8c50e4972444)

View Diff